Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: merge single-host spans in the UI #2302

Closed
wants to merge 1 commit into from

Conversation

codefromthecrypt
Copy link
Member

Finally we can fix #1799 not that the UI code uses a tree internally

Consider you are using single-host spans (ex disabling join), with this change, the UI can merge them together as if they were in the same span. The new UI (Zipkin Lens) will likely handle this differently.. this is just a stop-gap.

Note: the UI currently re-parents the children of the server to the client span. I hypothesise most won't notice (as they don't l look at parentId in the UI only span Id). This is the cheapest way to support the feature, but we can do more if important. Do mention if it is.

cc @openzipkin/ui @openzipkin/core

Before:
screen shot 2018-12-01 at 9 20 01 am

screen shot 2018-12-01 at 9 26 21 am

screen shot 2018-12-01 at 9 26 15 am

After:
screen shot 2018-12-01 at 9 19 41 am
screen shot 2018-12-01 at 9 25 49 am

@codefromthecrypt
Copy link
Member Author

will fix add tests etc after a few votes come in

@bogdandrutu
Copy link

@adriancole why not modify the client span-id to be server span-id?

@codefromthecrypt
Copy link
Member Author

codefromthecrypt commented Dec 1, 2018 via email

@codefromthecrypt
Copy link
Member Author

@tacigar probably better to do this in lens and not in the old UI. sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zipkin-ui does not support non-shared spans
2 participants