WIP: merge single-host spans in the UI #2302
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally we can fix #1799 not that the UI code uses a tree internally
Consider you are using single-host spans (ex disabling join), with this change, the UI can merge them together as if they were in the same span. The new UI (Zipkin Lens) will likely handle this differently.. this is just a stop-gap.
Note: the UI currently re-parents the children of the server to the client span. I hypothesise most won't notice (as they don't l look at parentId in the UI only span Id). This is the cheapest way to support the feature, but we can do more if important. Do mention if it is.
cc @openzipkin/ui @openzipkin/core
Before:
After: