Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 2: Reduce number of variable sources. Bundle variables. #498

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Part 2: Reduce number of variable sources. Bundle variables. #498

merged 2 commits into from
Nov 3, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Oct 31, 2023 •
edited
Loading

Description

Spliting #460 into smaller chunks. Related to #437

In this part I extract code related to creating bundle variables from BundlesAndDepsVariableSource into a separate function.

BundlesAndDepsVariableSource will be removed later in #501

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Merged
Merged
@m1kola m1kola mentioned this pull request Oct 31, 2023
Closed
4 tasks
@m1kola m1kola changed the title Part 2: Reduce number of variable sources Part 2: Reduce number of variable sources. Bundle variables. Oct 31, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c3176d) 84.11% compared to head (8ecced7) 84.41%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
+ Coverage   84.11%   84.41%   +0.30%     
==========================================
  Files          23       23              
  Lines         875      892      +17     
==========================================
+ Hits          736      753      +17     
  Misses         95       95              
  Partials       44       44
Flag Coverage Δ
e2e 65.91% <70.37%> (+0.09%) ⬆️
unit 79.54% <96.29%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/resolution/variablesources/bundle.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola force-pushed the shrink_variable_sources_p2 branch 5 times, most recently from 8d2811d to c9a1ea5 Compare November 2, 2023 11:27
@m1kola m1kola force-pushed the shrink_variable_sources_p2 branch 3 times, most recently from 05bd2d7 to 237206a Compare November 2, 2023 16:29
@m1kola m1kola mentioned this pull request Nov 2, 2023
Closed
8 tasks
@m1kola m1kola marked this pull request as ready for review November 2, 2023 17:09
@m1kola m1kola requested a review from a team as a code owner November 2, 2023 17:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023
@m1kola
Copy link
Member Author

m1kola commented Nov 2, 2023 •
edited
Loading

@joelanford please take another look. I believe I addressed all your feedback.

@m1kola m1kola mentioned this pull request Nov 3, 2023
Closed
@m1kola m1kola mentioned this pull request Nov 3, 2023
Merged
4 tasks
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@m1kola
Copy link
Member Author

m1kola commented Nov 3, 2023

Moveing back to draft for now becuase it needs a bit more work after #508 + address feedback.

@m1kola m1kola marked this pull request as draft November 3, 2023 14:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@m1kola
Move files
86bf448 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
Move bundle variable code into a func
8ecced7 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@m1kola m1kola marked this pull request as ready for review November 3, 2023 15:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@m1kola
Copy link
Member Author

m1kola commented Nov 3, 2023

@stevekuznetsov @joelanford rebased on top of #508 + addressed feedback. Please take another look

@m1kola m1kola added this pull request to the merge queue Nov 3, 2023
Merged via the queue into operator-framework:main with commit 36cd3c8 Nov 3, 2023
12 checks passed
@m1kola m1kola deleted the shrink_variable_sources_p2 branch November 6, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@joelanford joelanford Awaiting requested review from joelanford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m1kola @joelanford @stevekuznetsov @openshift-merge-robot