Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Improve error message about missing bundles #509

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 3, 2023

Description

Follow up for #498 (comment)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@m1kola m1kola marked this pull request as ready for review November 3, 2023 16:35
@m1kola m1kola requested a review from a team as a code owner November 3, 2023 16:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@m1kola m1kola changed the title Improve error message about missing bundlesImprove error message Improve error message about missing bundles Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aca6451) 84.41% compared to head (97aa4d1) 84.19%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   84.41%   84.19%   -0.23%     
==========================================
  Files          23       23              
  Lines         892      892              
==========================================
- Hits          753      751       -2     
- Misses         95       96       +1     
- Partials       44       45       +1     
Flag Coverage Δ
e2e 65.69% <0.00%> (-0.23%) ⬇️
unit 79.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/resolution/variablesources/bundle.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncdc ncdc changed the title Improve error message about missing bundles 🌱 Improve error message about missing bundles Nov 6, 2023
@m1kola m1kola added this pull request to the merge queue Nov 6, 2023
Merged via the queue into operator-framework:main with commit 69db2ad Nov 6, 2023
14 of 15 checks passed
@m1kola m1kola deleted the improve_error_message branch November 7, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants