refactor: moved constants to separated files #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- encoded the package name to ensure the link will open properly
…into feature/e2e-tests
…d `tag-names.js`
rzarviv
changed the title
baruchiro
requested changes
Jun 25, 2023
src/utils/tag-names.js
Outdated
| @@ -0,0 +1 @@ | |||
| export const packageReportTagName = 'overlay-package-report'; | |||
There was a problem hiding this comment.
Please add the 'overlay-indicator' to here too.
- deleted `e2e-test-constnats.js`
baruchiro
reviewed
Jul 2, 2023
src/globals.js
Outdated
| export const advisoriesNames = Object.keys(advisories); | ||
|
|
||
| export const packageReportTagName = 'overlay-package-report'; | ||
| export const tooltipSourceSelector = '.overlay-indicator__tooltip__sources > .overlay-indicator__tooltip__source'; |
There was a problem hiding this comment.
Don't know... I prefer the selector to stay in the tests area.
|
Hey! This pull request was made a few days ago and still needs changes, but nothing has happened since then. Maybe the current contributor can comment on this? |
|
Due to a long period of inactivity, this task was unassigned automatically. |
baruchiro
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this discussion I renamed
PACKAGE_REPORT_SELECTORtopackageReportTagNameand moved it to a new file calledtag-naems.js