Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify attribute handling using new @attr features #4476

Merged
merged 2 commits into from
Jan 25, 2025

Apply suggestions from code review

b346152
Select commit
Loading
Failed to load commit list.
Merged

Simplify attribute handling using new @attr features #4476

Apply suggestions from code review
b346152
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 0s

84.55% (-0.01%) compared to 3932f48, passed because coverage increased by 0% when compared to adjusted base (84.55%)

View this Pull Request on Codecov

84.55% (-0.01%) compared to 3932f48, passed because coverage increased by 0% when compared to adjusted base (84.55%)

Details

Codecov Report

Attention: Patch coverage is 85.07937% with 47 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (3932f48) to head (b346152).

Files with missing lines Patch % Lines
src/Rings/mpoly-localizations.jl 35.29% 11 Missing ⚠️
...ry/Schemes/ProjectiveSchemes/Objects/Attributes.jl 53.84% 6 Missing ⚠️
...ry/Schemes/ProjectiveSchemes/Objects/Properties.jl 75.00% 6 Missing ⚠️
.../AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl 87.17% 5 Missing ⚠️
...raicGeometry/Surfaces/EllipticSurface/Morphisms.jl 0.00% 4 Missing ⚠️
...perimental/Schemes/src/ToricDivisors/attributes.jl 80.00% 3 Missing ⚠️
...try/ToricVarieties/cohomCalg/special_attributes.jl 88.23% 2 Missing ⚠️
src/Groups/matrices/form_group.jl 88.88% 2 Missing ⚠️
src/Modules/Posur.jl 77.77% 2 Missing ⚠️
src/Rings/mpoly-ideals.jl 94.59% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4476      +/-   ##
==========================================
- Coverage   84.55%   84.55%   -0.01%     
==========================================
  Files         672      672              
  Lines       88875    88811      -64     
==========================================
- Hits        75145    75090      -55     
+ Misses      13730    13721       -9
Files with missing lines Coverage Δ
...heoryTools/src/AbstractFTheoryModels/attributes.jl 100.00% <100.00%> (ø)
...Tools/src/FamilyOfG4Fluxes/special_constructors.jl 77.41% <100.00%> (+0.30%) ⬆️
...ometry/Schemes/AffineSchemes/Objects/Attributes.jl 91.66% <100.00%> (-0.06%) ⬇️
...metry/Schemes/CoveredSchemes/Objects/Attributes.jl 98.18% <100.00%> (-0.04%) ⬇️
...icGeometry/Schemes/FunctionField/FunctionFields.jl 81.10% <100.00%> (-0.08%) ⬇️
...ometry/Surfaces/EllipticSurface/EllipticSurface.jl 83.62% <100.00%> (-0.03%) ⬇️
.../ToricVarieties/NormalToricVarieties/attributes.jl 98.67% <100.00%> (-0.01%) ⬇️
src/Groups/group_characters.jl 96.39% <100.00%> (ø)
src/Modules/mpolyquo-localizations.jl 88.76% <100.00%> (-0.13%) ⬇️
src/Rings/MPolyMap/AffineAlgebras.jl 95.95% <100.00%> (-0.05%) ⬇️
... and 18 more

... and 1 file with indirect coverage changes

View more details on Codecov