Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify attribute handling using new @attr features #4476

Merged
merged 2 commits into from
Jan 25, 2025

Apply suggestions from code review

b346152
Select commit
Loading
Failed to load commit list.
Merged

Simplify attribute handling using new @attr features #4476

Apply suggestions from code review
b346152
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 22, 2025 in 0s

85.07% of diff hit (target 84.55%)

View this Pull Request on Codecov

85.07% of diff hit (target 84.55%)

Annotations

Check warning on line 175 in experimental/FTheoryTools/src/AbstractFTheoryModels/properties.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/FTheoryTools/src/AbstractFTheoryModels/properties.jl#L175 

Added line #L175 was not covered by tests

Check warning on line 51 in experimental/FTheoryTools/src/G4Fluxes/auxiliary.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/FTheoryTools/src/G4Fluxes/auxiliary.jl#L51 

Added line #L51 was not covered by tests

Check warning on line 76 in experimental/Schemes/src/NormalToricVarieties/attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/NormalToricVarieties/attributes.jl#L76 

Added line #L76 was not covered by tests

Check warning on line 67 in experimental/Schemes/src/ToricDivisors/attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

experimental/Schemes/src/ToricDivisors/attributes.jl#L65-L67 

Added lines #L65 - L67 were not covered by tests

Check warning on line 613 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Attributes.jl#L610-L613 

Added lines #L610 - L613 were not covered by tests

Check warning on line 615 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Attributes.jl#L615 

Added line #L615 was not covered by tests

Check warning on line 618 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Attributes.jl#L618 

Added line #L618 was not covered by tests

Check warning on line 65 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl#L65 

Added line #L65 was not covered by tests

Check warning on line 72 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl#L71-L72 

Added lines #L71 - L72 were not covered by tests

Check warning on line 89 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl#L89 

Added line #L89 was not covered by tests

Check warning on line 97 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl#L97 

Added line #L97 was not covered by tests

Check warning on line 106 in src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Objects/Properties.jl#L106 

Added line #L106 was not covered by tests

Check warning on line 688 in src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl#L687-L688 

Added lines #L687 - L688 were not covered by tests

Check warning on line 1504 in src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl#L1503-L1504 

Added lines #L1503 - L1504 were not covered by tests

Check warning on line 1506 in src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl#L1506 

Added line #L1506 was not covered by tests

Check warning on line 100 in src/AlgebraicGeometry/Surfaces/EllipticSurface/Morphisms.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/Surfaces/EllipticSurface/Morphisms.jl#L97-L100 

Added lines #L97 - L100 were not covered by tests

Check warning on line 255 in src/AlgebraicGeometry/ToricVarieties/CohomologyClasses/special_attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/ToricVarieties/CohomologyClasses/special_attributes.jl#L255 

Added line #L255 was not covered by tests

Check warning on line 179 in src/AlgebraicGeometry/ToricVarieties/cohomCalg/special_attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/ToricVarieties/cohomCalg/special_attributes.jl#L179 

Added line #L179 was not covered by tests

Check warning on line 188 in src/AlgebraicGeometry/ToricVarieties/cohomCalg/special_attributes.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/AlgebraicGeometry/ToricVarieties/cohomCalg/special_attributes.jl#L188 

Added line #L188 was not covered by tests

Check warning on line 708 in src/Groups/matrices/form_group.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/Groups/matrices/form_group.jl#L708 

Added line #L708 was not covered by tests

Check warning on line 722 in src/Groups/matrices/form_group.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/Groups/matrices/form_group.jl#L722 

Added line #L722 was not covered by tests

Check warning on line 249 in src/Modules/Posur.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/Modules/Posur.jl#L249 

Added line #L249 was not covered by tests

Check warning on line 252 in src/Modules/Posur.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/Modules/Posur.jl#L252 

Added line #L252 was not covered by tests

Check warning on line 625 in src/Rings/mpoly-ideals.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/Rings/mpoly-ideals.jl#L625 

Added line #L625 was not covered by tests

Check warning on line 672 in src/Rings/mpoly-ideals.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/Rings/mpoly-ideals.jl#L672 

Added line #L672 was not covered by tests
View more details on Codecov