Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 make line/slope switching available to authors / TAS-720 #4207

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Nov 22, 2024

Make line/slope chart switching available to authors by:

  • adding a Slope chart toggle in the admin
  • adding 'LineChart SlopeChart' as an option for the type column

I considered renaming the type column in explorers to chartTypes but other than consistency there is little benefit.

@sophiamersmann sophiamersmann changed the title 🎉 (admin) add slope chart toggle 🎉 make line/slope switching available for authors Nov 22, 2024
@sophiamersmann sophiamersmann changed the title 🎉 make line/slope switching available for authors 🎉 make line/slope switching available to authors Nov 22, 2024
@sophiamersmann sophiamersmann changed the title 🎉 make line/slope switching available to authors 🎉 make line/slope switching available to authors / TAS-720 Nov 22, 2024
Copy link

@owidbot
Copy link
Contributor

owidbot commented Nov 22, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-admin-slope-viz

SVG tester:

Number of differences (default views): 1364 (a6be0b) ❌
Number of differences (all views): 486 (8132b4) ❌

Edited: 2024-12-11 12:35:52 UTC
Execution time: 1.34 seconds

@sophiamersmann sophiamersmann force-pushed the admin-slope-viz branch 2 times, most recently from 532b279 to d0530c8 Compare November 26, 2024 09:21
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

adminSiteClient/EditorBasicTab.tsx Outdated Show resolved Hide resolved
Copy link
Member Author

sophiamersmann commented Dec 11, 2024

Merge activity

  • Dec 11, 7:47 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 11, 8:02 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 11, 8:03 AM EST: A user merged this pull request with Graphite.

@sophiamersmann sophiamersmann changed the base branch from slope-facets-viz to graphite-base/4207 December 11, 2024 12:57
@sophiamersmann sophiamersmann changed the base branch from graphite-base/4207 to master December 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants