-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 (slope) support facetting / TAS-734 #4247
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c068c3a
to
9549933
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 1364 (3ccd51) ❌ Edited: 2024-12-11 12:34:31 UTC |
9549933
to
93fa1cd
Compare
c889061
to
c2578d0
Compare
12af29a
to
1736d95
Compare
c2578d0
to
f4b494e
Compare
62d93d8
to
09ff137
Compare
a96f0a2
to
5f84cc6
Compare
09ff137
to
fce778c
Compare
5f84cc6
to
1afb4ee
Compare
fce778c
to
22d79ba
Compare
There's a weird thing going on where on http://staging-site-slope-charts/grapher/antibiotic-usage-by-surveillance-category?tab=slope&time=2020..2022, the line connectors are only shown when Uganda is removed - even though the chart size itself is the same no matter what: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for the bug I just commented about 🙌
No worries if you can't address that bug - it's not a dealbreaker!
823160b
to
fa1a521
Compare
This happened because slope charts without data used a default domain extent of [-1, 1]. I pushed a fix! |
e611451
to
3b6b7fe
Compare
cbf6d9a
to
e0c42f6
Compare
3b6b7fe
to
f29f46f
Compare
e0c42f6
to
464a640
Compare
f29f46f
to
a7711ac
Compare
464a640
to
a71812f
Compare
a7711ac
to
d95d75e
Compare
a71812f
to
f7aaf16
Compare
d95d75e
to
ff011e9
Compare
f7aaf16
to
b1cee49
Compare
b1cee49
to
71deb74
Compare
Adds facetting support for slope charts.
If there are many facets it could be nice to declutter them, but I don't have time for that now.