Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 (slope) support facetting / TAS-734 #4247

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Dec 3, 2024

Adds facetting support for slope charts.

If there are many facets it could be nice to declutter them, but I don't have time for that now.

@sophiamersmann sophiamersmann changed the title 🎉 (slope) support facetting 🎉 (slope) support facetting / TAS-734 Dec 3, 2024
Copy link

@owidbot
Copy link
Contributor

owidbot commented Dec 3, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-slope-facets-viz

SVG tester:

Number of differences (default views): 1364 (3ccd51) ❌
Number of differences (all views): 486 (2ffe19) ❌

Edited: 2024-12-11 12:34:31 UTC
Execution time: 1.37 seconds

@marcelgerber
Copy link
Member

There's a weird thing going on where on http://staging-site-slope-charts/grapher/antibiotic-usage-by-surveillance-category?tab=slope&time=2020..2022, the line connectors are only shown when Uganda is removed - even though the chart size itself is the same no matter what:

CleanShot 2024-12-09 at 18 15 00
CleanShot 2024-12-09 at 18 15 59

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the bug I just commented about 🙌

No worries if you can't address that bug - it's not a dealbreaker!

@sophiamersmann
Copy link
Member Author

This happened because slope charts without data used a default domain extent of [-1, 1]. I pushed a fix!

Copy link
Member Author

sophiamersmann commented Dec 11, 2024

Merge activity

  • Dec 11, 7:47 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 11, 7:58 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 11, 7:59 AM EST: A user merged this pull request with Graphite.

@sophiamersmann sophiamersmann changed the base branch from slope-redesign-viz to graphite-base/4247 December 11, 2024 12:53
@sophiamersmann sophiamersmann changed the base branch from graphite-base/4247 to master December 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants