Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 (line legend) add tests for dropping labels #4309

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Dec 16, 2024

Adds tests in preparation for a refactor of the code responsible for dropping labels when there is not enough space.

I also renamed some of the computed values in the line legend component for clarity.

The SVG tester comes back with a difference because there was a small issue about label padding that I fixed.

@owidbot
Copy link
Contributor

owidbot commented Dec 16, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-line-legend-tests-viz

SVG tester:

Number of differences (default views): 2 (763b68) ❌
Number of differences (all views): 0 ✅

Edited: 2024-12-19 10:39:16 UTC
Execution time: 1.47 seconds

@sophiamersmann sophiamersmann force-pushed the default-config-empty-arrays-viz branch from dca509b to 684cf54 Compare December 17, 2024 10:31
@sophiamersmann sophiamersmann force-pushed the default-config-empty-arrays-viz branch from 684cf54 to a1f8570 Compare December 17, 2024 15:33
@sophiamersmann sophiamersmann force-pushed the default-config-empty-arrays-viz branch from a1f8570 to 7db7446 Compare December 17, 2024 15:57
@sophiamersmann sophiamersmann changed the base branch from default-config-empty-arrays-viz to graphite-base/4309 December 17, 2024 16:31
@sophiamersmann sophiamersmann changed the base branch from graphite-base/4309 to master December 17, 2024 16:34
@sophiamersmann sophiamersmann force-pushed the line-legend-tests-viz branch 2 times, most recently from 7b66a4d to c415e0b Compare December 18, 2024 09:51
@sophiamersmann sophiamersmann marked this pull request as ready for review December 18, 2024 10:14
Copy link
Member Author

sophiamersmann commented Dec 19, 2024

Merge activity

  • Dec 19, 7:11 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 7:12 AM EST: A user merged this pull request with Graphite.

@sophiamersmann sophiamersmann merged commit 332107f into master Dec 19, 2024
21 checks passed
@sophiamersmann sophiamersmann deleted the line-legend-tests-viz branch December 19, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants