-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 (line legend) add tests for dropping labels #4309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
This was referenced Dec 16, 2024
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
2 times, most recently
from
December 16, 2024 10:40
0f14805
to
23f6d25
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 2 (763b68) ❌ Edited: 2024-12-19 10:39:16 UTC |
sophiamersmann
force-pushed
the
default-config-empty-arrays-viz
branch
from
December 17, 2024 10:31
dca509b
to
684cf54
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
December 17, 2024 10:31
23f6d25
to
1efc37f
Compare
sophiamersmann
force-pushed
the
default-config-empty-arrays-viz
branch
from
December 17, 2024 15:33
684cf54
to
a1f8570
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
December 17, 2024 15:34
1efc37f
to
ff455a2
Compare
sophiamersmann
force-pushed
the
default-config-empty-arrays-viz
branch
from
December 17, 2024 15:57
a1f8570
to
7db7446
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
December 17, 2024 15:57
ff455a2
to
46aec6b
Compare
sophiamersmann
changed the base branch from
default-config-empty-arrays-viz
to
graphite-base/4309
December 17, 2024 16:31
sophiamersmann
force-pushed
the
graphite-base/4309
branch
from
December 17, 2024 16:34
7db7446
to
0769513
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
December 17, 2024 16:34
46aec6b
to
91ab2bd
Compare
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
2 times, most recently
from
December 18, 2024 09:51
7b66a4d
to
c415e0b
Compare
marcelgerber
approved these changes
Dec 18, 2024
sophiamersmann
force-pushed
the
line-legend-tests-viz
branch
from
December 19, 2024 10:24
c415e0b
to
df36918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests in preparation for a refactor of the code responsible for dropping labels when there is not enough space.
I also renamed some of the computed values in the line legend component for clarity.
The SVG tester comes back with a difference because there was a small issue about label padding that I fixed.