[select,datetime2] support popoverProps.targetTagName #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused importPreviews: documentation | landing | table | demo |
fix test compilationPreviews: documentation | landing | table | demo |
|
Looks good in the preview build, although I did find this unrelated bug: #5714 |
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
While migrating a large codebase to Popover2, I noticed some v2 components no longer supported
popoverProps.targetTagNamelike they did with Popover. Although this use case is rare, I think we can continue supporting it in Popover2.This PR does a few things:
InputGroup): new proptagNameallows customizing the tag name of the HTML element that contains the input groupSelect2,Suggest2,MultiSelect2): restore support forpopoverProps={{ targetTagName }}, which was previously available in the v1 components with<Popover>DateInput2,DateRangeInput2): restore support forpopoverProps={{ targetTagName }}, which was previously available in the v1 components with<Popover>DateInput2,DateRangeInput2): new proppopoverRefallows access to the Popover2 instance, sometimes useful for repositioning the popoverReviewers should focus on:
No regressions
Screenshot