[popover2] feat(Popover2, Tooltip2): make component type param optional #5734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
It turns out #5713 also had a typings regression for the
popoverRef
prop on datetime2 & select components, specifically the bit withReact.HTMLProps<unknown>
. In trying to improve this type definition, I found myself writingReact.HTMLProps<HtmlElement>
in a lot of places, since that's the default assumed in the definition ofPopover2Props<T = ...>
. It seems like we can actually just define this as the default in thePopover2
class definition and avoid specifying the type param in most cases. I'm not exactly sure why this wasn't the case before (T
was required if referencingPopover2
as a type), but this will make these type references a lot simpler in our codebase and for consumers.