[popover2] feat: export DefaultPopover2TargetHTMLProps #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #5734, which did not work...
Changes proposed in this pull request:
It turns out #5713 also had a typings regression for the
popoverRefprop on datetime2 & select components, specifically the bit withReact.HTMLProps<unknown>. In trying to improve this type definition, I found myself writingReact.HTMLProps<HtmlElement>in a lot of places, since that's the default assumed in the definition ofPopover2Props<T = ...>. That's now fixed in the public API of @blueprintjs/popover2 with the new typeDefaultPopover2TargetHTMLProps.changelog:
DefaultPopover2TargetHTMLPropsDateInput2,DateRangeInput2): type definition ofpopoverRefprop is now usable in most cases without type castingSelect2,Suggest2,MultiSelect2): type definition ofpopoverRefprop no longer has the regression introduced in v4.8.8 with [select,datetime2] support popoverProps.targetTagName #5713