-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parity-crypto] Derive Debug for digests and signatures #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `verify` to take ownership of the inner value, which is backwards incompatible.
dvdplm
changed the title
Derive Debug for digests and signatures
[parity-crypto] Derive Debug for digests and signatures
May 15, 2019
ordian
approved these changes
May 15, 2019
ascjones
approved these changes
May 15, 2019
niklasad1
reviewed
May 16, 2019
niklasad1
approved these changes
May 16, 2019
ordian
added a commit
to ordian/parity-common
that referenced
this pull request
May 16, 2019
* paritytech/master: [parity-bytes] add no-std support (paritytech#154) [parity-crypto] Derive Debug for digests and signatures (paritytech#155) Restore the previous API to allow variable size keys for Hmac operations (paritytech#152) Implemented TryFrom<biguint> for primitives (paritytech#148)
dvdplm
added a commit
that referenced
this pull request
May 19, 2019
* master: [parity-crypto] zero memory for hmac signing keys (#157) Added absolute path for 'Result' usage in macros to avoid type collisions. (#160) [parity-bytes] add no-std support (#154) [parity-crypto] Derive Debug for digests and signatures (#155) Restore the previous API to allow variable size keys for Hmac operations (#152) Implemented TryFrom<biguint> for primitives (#148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #152, only 20e8f69 is new here.