[parity-crypto] zero memory for hmac signing keys #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `verify` to take ownership of the inner value, which is backwards incompatible.
…fix/zero-memory-for-hmac-signing-keys * 'master' of github.com:paritytech/parity-common: [parity-bytes] add no-std support (#154)
dvdplm
changed the title
ordian
approved these changes
May 16, 2019
kirushik
approved these changes
May 17, 2019
ordian
reviewed
May 17, 2019
dvdplm
added a commit
that referenced
this pull request
May 19, 2019
* master: [parity-crypto] zero memory for hmac signing keys (#157) Added absolute path for 'Result' usage in macros to avoid type collisions. (#160) [parity-bytes] add no-std support (#154) [parity-crypto] Derive Debug for digests and signatures (#155) Restore the previous API to allow variable size keys for Hmac operations (#152) Implemented TryFrom<biguint> for primitives (#148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #156
The main reason for the
DisposableBoxis to enable some testing. I'm really not sure if the test added is actually meaningful but I couldn't come up with anything better. Input appreciated.