Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add absolute path for 'Result' type usage in macros #160

Merged
merged 1 commit into from
May 17, 2019
Merged

Add absolute path for 'Result' type usage in macros #160

merged 1 commit into from
May 17, 2019

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented May 17, 2019

I noticed Result type is used in some macros without $crate::core_::result:: path. This could lead to type collisions, if the context where macro used has another Result type.

// won't compile
use my_module::Result;
// ...
construct_uint! {
	pub struct U256(4);
}

@parity-cla-bot
Copy link

It looks like @shaopengw signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@ordian ordian merged commit eade515 into paritytech:master May 17, 2019
dvdplm added a commit that referenced this pull request May 19, 2019
@dvdplm
Merge branch 'master' into dp/chore/prep-parity-crypto-for-release
53254a4 
* master:
  [parity-crypto] zero memory for hmac signing keys (#157)
  Added absolute path for 'Result' usage in macros to avoid type collisions. (#160)
  [parity-bytes] add no-std support   (#154)
  [parity-crypto] Derive Debug for digests and signatures (#155)
  Restore the previous API to allow variable size keys for Hmac operations (#152)
  Implemented TryFrom<biguint> for primitives (#148)
dvdplm added a commit that referenced this pull request May 23, 2019
@dvdplm
Merge branch 'master' into dp/chore/update-rlp-to-ethereum-types-0.5
1cc5e43 
* master:
  Remove unused test support files (#162)
  [parity-crypto] bump version to 0.4.0 (#149)
  [parity-crypto] zero memory for hmac signing keys (#157)
  Added absolute path for 'Result' usage in macros to avoid type collisions. (#160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaunxw @parity-cla-bot @dvdplm @ordian