Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parity-crypto] bump version to 0.4.0 #149

Merged
merged 12 commits into from
May 23, 2019
Merged

[parity-crypto] bump version to 0.4.0 #149

merged 12 commits into from
May 23, 2019

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented May 13, 2019

No description provided.

@ordian
Copy link
Member

ordian commented May 13, 2019

why beta? :)

@dvdplm
Copy link
Contributor Author

dvdplm commented May 13, 2019

@tomaka published 0.4-beta.1 if you need it.

@dvdplm
Copy link
Contributor Author

dvdplm commented May 13, 2019

why beta? :)

I wanted to see what breaks in parity-ethereum.

@ordian
Copy link
Member

ordian commented May 13, 2019

I'm not expecting much breakage except for reverting openethereum/parity-ethereum@b347599.

@tomaka
Copy link
Contributor

tomaka commented May 13, 2019

Let's publish the real 0.4!

@ordian
Copy link
Member

ordian commented May 13, 2019

Do we want to update scrypt before publishing 0.4?

@dvdplm
Copy link
Contributor Author

dvdplm commented May 13, 2019

Do we want to update scrypt before publishing 0.4?

That seems sensible, should avoid some duplicate crates. It seems to replace constant_time_eq with subtle though (here) – is that a worry to us? Should we switch to using it too perhaps?

@ordian
Copy link
Member

ordian commented May 13, 2019

That seems sensible, should avoid some duplicate crates. It seems to replace constant_time_eq with subtle though (here) – is that a worry to us? Should we switch to using it too perhaps?

I don't know what was the reasoning for script for switsching, maybe we should investigate. Do we use that feature though? (seems like we don't: default-features = false)

@ordian
Copy link
Member

ordian commented May 13, 2019

Should we switch to using it too perhaps?

I think we should, it's made by dalek-cryptography team and seems to be more maintained.

@ordian
Copy link
Member

ordian commented May 13, 2019

Also, it would be nice to document breaking changes as API guidelines suggest.

@dvdplm
Copy link
Contributor Author

dvdplm commented May 13, 2019

@ordian updated the README and switched to subtle and newest scrypt.

tomaka
tomaka reviewed May 13, 2019
View reviewed changes
parity-crypto/Cargo.toml Outdated Show resolved Hide resolved
ordian
ordian reviewed May 13, 2019
View reviewed changes
parity-crypto/README.md Outdated Show resolved Hide resolved
ordian
ordian previously requested changes May 13, 2019
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for #139 (comment) to be resolved

parity-crypto/README.md Outdated Show resolved Hide resolved
@dvdplm
Fix hash sizes
01c8860
@dvdplm
Improve wording
366452e
@dvdplm
Remove mention of secp256k1 – not available in this lib.
393aefc
@dvdplm
Merge branch 'master' into dp/chore/prep-parity-crypto-for-release
53254a4 
* master:
  [parity-crypto] zero memory for hmac signing keys (#157)
  Added absolute path for 'Result' usage in macros to avoid type collisions. (#160)
  [parity-bytes] add no-std support   (#154)
  [parity-crypto] Derive Debug for digests and signatures (#155)
  Restore the previous API to allow variable size keys for Hmac operations (#152)
  Implemented TryFrom<biguint> for primitives (#148)
@dvdplm dvdplm requested a review from ordian May 19, 2019 16:56
ordian
ordian reviewed May 22, 2019
View reviewed changes
parity-crypto/src/error.rs Outdated Show resolved Hide resolved
parity-crypto/src/error.rs Outdated Show resolved Hide resolved
parity-crypto/src/error.rs Outdated Show resolved Hide resolved
@dvdplm dvdplm mentioned this pull request May 22, 2019
Merged
ordian
ordian approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's publish 0.4.0!

@dvdplm
Copy link
Contributor Author

dvdplm commented May 22, 2019

0.4 is published

@dvdplm dvdplm merged commit 7c49d47 into master May 23, 2019
@tomaka tomaka deleted the dp/chore/prep-parity-crypto-for-release branch May 23, 2019 08:18
@tomaka tomaka restored the dp/chore/prep-parity-crypto-for-release branch May 23, 2019 08:18
@ordian ordian deleted the dp/chore/prep-parity-crypto-for-release branch May 23, 2019 09:41
@ordian ordian restored the dp/chore/prep-parity-crypto-for-release branch May 23, 2019 09:41
@ordian ordian deleted the dp/chore/prep-parity-crypto-for-release branch May 23, 2019 10:02
dvdplm added a commit that referenced this pull request May 23, 2019
@dvdplm
Merge branch 'master' into dp/chore/update-rlp-to-ethereum-types-0.5
1cc5e43 
* master:
  Remove unused test support files (#162)
  [parity-crypto] bump version to 0.4.0 (#149)
  [parity-crypto] zero memory for hmac signing keys (#157)
  Added absolute path for 'Result' usage in macros to avoid type collisions. (#160)
@ordian ordian mentioned this pull request Sep 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka tomaka approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvdplm @ordian @tomaka