Add RPC eth_chainId for querying the current blockchain chain ID #6329

sorpaas · 2017-08-18T09:24:09Z

Currently although we can use net_version RPC call to get the
current network ID, there's no RPC for querying the chain ID. This
makes it impossible to determine the current actual blockchain using
the RPC. An ETH/ETC client can accidentally connect to an ETC/ETH RPC
endpoint without knowing it unless it tries to sign a transaction or
it fetch a transaction that is known to have signed with a chain
ID. This has since caused trouble for application developers, such as
MetaMask, to add multi-chain support.

The same RPC endpoint is also about to be merged for ETC's
go-ethereum: ethereumproject/go-ethereum#336

Currently although we can use `net_version` RPC call to get the current network ID, there's no RPC for querying the chain ID. This makes it impossible to determine the current actual blockchain using the RPC. An ETH/ETC client can accidentally connect to an ETC/ETH RPC endpoint without knowing it unless it tries to sign a transaction or it fetch a transaction that is known to have signed with a chain ID. This has since caused trouble for application developers, such as MetaMask, to add multi-chain support. The same RPC endpoint is also about to be merged for ETC's go-ethereum: ethereumproject/go-ethereum#336

parity-cla-bot · 2017-08-18T09:24:12Z

It looks like @sorpaas hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

sorpaas · 2017-08-18T09:40:31Z

[clabot:check]

parity-cla-bot · 2017-08-18T09:40:33Z

It looks like @sorpaas signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

tcz001 · 2017-08-21T01:14:14Z

+1 on this PR, I faced with this problem when using web3.js which is using the getId by default

tcz001 · 2017-08-21T02:41:48Z

Just created a EIP694

tomusdrw

A small grumble regarding types.

Also this pollutes eth_* namespace and it has been agreed that those namespaces are reserved only for cross-client compatbile RPC methods that preferrable has gone through the EIP process.

tomusdrw · 2017-08-21T11:42:15Z

rpc/src/v1/impls/eth.rs

@@ -284,6 +284,11 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM> Eth for EthClient<C, SN, S, M, EM> where
 		Ok(format!("{}", version))
 	}

+	fn chain_id(&self) -> Result<String, Error> {


Chain id in the transactions is serialized as Option<u64>, would be best to keep it constistent.
IMHO using a generic String response is a bit misleading. If we want to return a hex-encoded value then Option<U64> would be a right choice.

Note that using Option indicates that in case the chain id is missing null will be returned.

rphmeier · 2017-08-22T03:36:14Z

I also disagree with polluting the eth namespace just yet, but am definitely not opposed to the idea in general.

tcz001 · 2017-08-22T07:26:24Z

Agree, an int in string type would be better for extension and compatibility here, how about changing it in EIP694 @sorpaas & @whilei, any thoughts? In this case we need to modify the etc geth implementation accordingly.

whilei · 2017-08-22T13:18:24Z

@tcz001 I've created an EIP-rpc_chain_id as a PR (since it should be a PR rather than an issue) which is almost exactly like your issue EIP694 -- maybe we can switch to using the PR as a reference?

I used a bigint in hexadecimal because that's in line with the rest of the eth_-namespaced returnables, eg. https://github.com/ethereumproject/go-ethereum/wiki/JSON-RPC#eth_blocknumber.

tcz001 · 2017-08-22T23:38:01Z

Thx, will close that issue

tomusdrw · 2017-09-04T07:42:49Z

Build failure seems unrelated. Will be happy to merge under parity_chainId. After the method is accepted via EIP we can rename it to eth_chainId.

gavofyork · 2017-09-16T13:22:57Z

Tests fail with RPC_API_Test...error: An unknown error occurred.

…c/eth-chainId

u64 returns decimal integer, and there seems to be no type called U64. So here I use U256 to return the hex integer.

Before EIP155 fork number, chainID should be null.

tomusdrw · 2017-09-18T08:09:04Z

rpc/src/v1/impls/parity.rs

@@ -200,6 +200,10 @@ impl<C, M, U> Parity for ParityClient<C, M, U> where
 		Ok(self.settings.chain.clone())
 	}

+	fn chain_id(&self) -> Result<Option<U256>, Error> {


minor: U64 would be enough

As mentioned earlier chain_id is already returned as decimal (u64) in transactions and I'd prefer consistency (either all U64 (hex) or all u64 (decimal)).

@tomusdrw Where's the U64 struct defined?

Thought we already have it, but seems we only have U128 and U256. You can create U64 in types/uint.rs.

This makes it consistent that all chain ids returned are hex string.

rphmeier · 2017-09-18T13:12:25Z

rpc/src/v1/types/uint.rs

+
+impl serde::Serialize for U64 {
+	fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error> where S: serde::Serializer {
+		serializer.serialize_str(&format!("0x{}", self.0))


i don't think this will actually format as hex. maybe {:h}? @tomusdrw should it be left-padded with zeros?

sorpaas · 2017-09-18T13:50:48Z

gitlab-test-rust-stable was failed due to a connection timeout. Glad if someone can help to restart it.

gavofyork · 2017-09-26T11:05:01Z

@tomusdrw @rphmeier please verify all good.

* ethereum/EIPs#695 * Original PR is openethereum#6329

* Support eth_chainId RPC method * ethereum/EIPs#695 * Original PR is #6329 * rpc: remove parity_chainId

5chdn added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Aug 18, 2017

Add eth_chainId to js's web3 interface

7f8f215

sorpaas force-pushed the rpc/eth-chainId branch from 67ef961 to 7f8f215 Compare August 18, 2017 09:34

sorpaas added 2 commits August 18, 2017 17:35

Add a mocked test for eth_chainId

fb354fc

Add chainId in js's jsonrpc interfaces

87787d2

whilei mentioned this pull request Aug 18, 2017

eth,internal: add eth_chainId method to PublicEthereumApi JSONRPC ethereum/go-ethereum#15002

Closed

sorpaas mentioned this pull request Aug 18, 2017

Inconsistent JSON-RPC results for Ethereum Classic - network id #6330

Closed

tcz001 mentioned this pull request Aug 21, 2017

Add RPC eth_chainId for querying the current blockchain chain ID ethereum/EIPs#694

Closed

tomusdrw reviewed Aug 21, 2017

View reviewed changes

Change return type for eth_chainId to Option<u64>

c3cfa16

tomusdrw added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 4, 2017

sorpaas added 2 commits September 4, 2017 17:44

Change name eth_chainId to parity_chainId

9bea238

Wrong test name and missed var for rpc_parity_chain_id test

29dcabb

sorpaas added 3 commits September 18, 2017 03:29

Merge branch 'master' of https://github.com/paritytech/parity into rp…

64e2256

…c/eth-chainId

Use U256 to return chainId and fix for master

cf8e189

u64 returns decimal integer, and there seems to be no type called U64. So here I use U256 to return the hex integer.

Fix chainID test

b8beb21

Before EIP155 fork number, chainID should be null.

tomusdrw reviewed Sep 18, 2017

View reviewed changes

Change both parity_chainId and transaction::chainId to use U64

4da73e9

This makes it consistent that all chain ids returned are hex string.

rphmeier reviewed Sep 18, 2017

View reviewed changes

Fix wrong U64 serialization

1831fff

gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Sep 26, 2017

tomusdrw approved these changes Sep 26, 2017

View reviewed changes

tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 26, 2017

rphmeier approved these changes Sep 26, 2017

View reviewed changes

gavofyork merged commit d8af9f4 into openethereum:master Sep 26, 2017

axic mentioned this pull request Jan 26, 2018

Support eth_chainId ethereum/aleth#4810

Closed

hackmod mentioned this pull request Oct 19, 2018

support eth_chainId MetaMask/metamask-extension#5552

Merged

hackmod added a commit to EthersocialNetwork/parity-ethereum that referenced this pull request Oct 19, 2018

Support eth_chainId RPC method

90e9cec

* ethereum/EIPs#695 * Original PR is openethereum#6329

hackmod mentioned this pull request Oct 19, 2018

Support eth_chainId RPC method #9783

Merged

hackmod added a commit to EthersocialNetwork/parity-ethereum that referenced this pull request Oct 19, 2018

Support eth_chainId RPC method

18fc829

* ethereum/EIPs#695 * Original PR is openethereum#6329

hackmod added a commit to EthersocialNetwork/parity-ethereum that referenced this pull request Oct 19, 2018

Support eth_chainId RPC method

23b7f51

* ethereum/EIPs#695 * Original PR is openethereum#6329

sorpaas pushed a commit that referenced this pull request Oct 20, 2018

Support eth_chainId RPC method (#9783)

b8da38f

* Support eth_chainId RPC method * ethereum/EIPs#695 * Original PR is #6329 * rpc: remove parity_chainId

nivida mentioned this pull request Mar 24, 2019

"Transaction has been reverted by the EVM" deploying contract with version higher than 1.0.0-beta.46 web3/web3.js#2560

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RPC eth_chainId for querying the current blockchain chain ID #6329

Add RPC eth_chainId for querying the current blockchain chain ID #6329

sorpaas commented Aug 18, 2017

parity-cla-bot commented Aug 18, 2017

sorpaas commented Aug 18, 2017

parity-cla-bot commented Aug 18, 2017

tcz001 commented Aug 21, 2017

tcz001 commented Aug 21, 2017 •

edited

Loading

tomusdrw left a comment

tomusdrw Aug 21, 2017

rphmeier commented Aug 22, 2017

tcz001 commented Aug 22, 2017 •

edited

Loading

whilei commented Aug 22, 2017

tcz001 commented Aug 22, 2017

tomusdrw commented Sep 4, 2017

gavofyork commented Sep 16, 2017

tomusdrw Sep 18, 2017

sorpaas Sep 18, 2017

tomusdrw Sep 18, 2017

rphmeier Sep 18, 2017

sorpaas commented Sep 18, 2017

gavofyork commented Sep 26, 2017

Add RPC eth_chainId for querying the current blockchain chain ID #6329

Add RPC eth_chainId for querying the current blockchain chain ID #6329

Conversation

sorpaas commented Aug 18, 2017

parity-cla-bot commented Aug 18, 2017

sorpaas commented Aug 18, 2017

parity-cla-bot commented Aug 18, 2017

tcz001 commented Aug 21, 2017

tcz001 commented Aug 21, 2017 • edited Loading

tomusdrw left a comment

Choose a reason for hiding this comment

tomusdrw Aug 21, 2017

Choose a reason for hiding this comment

rphmeier commented Aug 22, 2017

tcz001 commented Aug 22, 2017 • edited Loading

whilei commented Aug 22, 2017

tcz001 commented Aug 22, 2017

tomusdrw commented Sep 4, 2017

gavofyork commented Sep 16, 2017

tomusdrw Sep 18, 2017

Choose a reason for hiding this comment

sorpaas Sep 18, 2017

Choose a reason for hiding this comment

tomusdrw Sep 18, 2017

Choose a reason for hiding this comment

rphmeier Sep 18, 2017

Choose a reason for hiding this comment

sorpaas commented Sep 18, 2017

gavofyork commented Sep 26, 2017

tcz001 commented Aug 21, 2017 •

edited

Loading

tcz001 commented Aug 22, 2017 •

edited

Loading