Bridges - changes for Bridges V2 - relay client part #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
added
R0-silent
svyatonik
force-pushed
the
bko-bridges-backports-and-nits
branch
from
1cdb84f
to
7a394d8
Compare
|
@svyatonik In traitified v2 client we are using shared subscriptions, so #4481 shouldn't be a problem when we talk about long-lived subscriptions (justification). But we need to test it for transaction subscriptions - right now I've rebased completely without #4481 |
bkontur
force-pushed
the
bko-bridges-backports-and-nits
branch
3 times, most recently
from
c4c55e2
to
12c59b5
Compare
bkontur
changed the title
3 tasks
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
…ble (#2206) * Avoid using extra background task for TransactionTracker * Add docs
* final check before transaction submit * pass pre-encoded transaction to validate
* read best + best finalized headers from subscription * spelling * clippy
bkontur
force-pushed
the
bko-bridges-backports-and-nits
branch
from
12c59b5
to
6a021c8
Compare
svyatonik
reviewed
May 23, 2024
There was a problem hiding this comment.
FWIW: all code changes were already reviewed before in a https://github.com/paritytech/parity-bridges-common/ repository. I did a shallow check and porting looks good and should work with all existing bridges. However I also want to perform that check: #4494 (comment). Will do that tomorrow and approve if all is ok or push some commits to fix it if changes are required
svyatonik
approved these changes
May 24, 2024
acatangiu
approved these changes
May 27, 2024
hitchhooker
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this pull request
Jun 5, 2024
Cherry-picked fix from upcoming paritytech#4494 --------- Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: command-bot <>
5 tasks
…mplemented for T: Client<C>
serban300
approved these changes
Jun 14, 2024
bkontur
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Jun 14, 2024
bkontur
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Jun 14, 2024
* Dienerized to polkadot-sdk@bko-bridges-backports-and-nits * cargo update -p sp-io * Change substrate-relay version * Update polkadot-sdk master ref * Setup latest master with merged: paritytech/polkadot-sdk#4494 * Change relayer version for release --------- Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Cherry-picked fix from upcoming paritytech#4494 --------- Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: command-bot <>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Contains mainly changes/nits/refactors related to the relayer code (`client-substrate` and `lib-substrate-relay`) migrated from the Bridges V2 [branch](paritytech#4427). Relates to: paritytech/parity-bridges-common#2976 Companion: paritytech/parity-bridges-common#2988 ## TODO - [x] fix comments ## Questions - [x] Do we need more testing for client V2 stuff? If so, how/what is the ultimate test? @svyatonik - [x] check [comment](paritytech#4494 (comment)) for more testing --------- Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Serban Iorga <serban@parity.io>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains mainly changes/nits/refactors related to the relayer code (
client-substrateandlib-substrate-relay) migrated from the Bridges V2 branch.Relates to: paritytech/parity-bridges-common#2976
Companion: paritytech/parity-bridges-common#2988
TODO
Questions