3437 environment variable to disable inlining images #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `e2e:docker` command can run tests in a Docker container, but it always returns exit code 0 even if the tests failed. This PR resolves that and returns the exit code from the test command.
* Upgrade svgr to 4.0.3 * Upgrade svgr to 4.0.4 * Remove unnecessary prettier option * Update to 4.1.0
* Changes to steps for publishing GitHub User Page Remove the the step for switching to gh-pages branch as it is no longer a viable option. * Changed projects to project
…acebook#6190) * Update updating-to-new-releases.md Related to facebook#6140 * Update updating-to-new-releases.md Linking to getting started following discussion on facebook#6190. Adapt terminology to current installation methods. * Update updating-to-new-releases.md typo, rleative link * Update docusaurus/docs/updating-to-new-releases.md Co-Authored-By: carpben <carpben@users.noreply.github.com>
* [docs] Change serve port flag and add example * [docs] Add --listen flag
* fix e2e:docker issue * fix e2e tests
As a lot of [people](https://hackernoon.com/why-i-no-longer-use-typescript-with-react-and-why-you-shouldnt-either-e744d27452b4) is complaining about TypeScript performance in CRA, I decided to enable `async` mode in TypeScript checker. These changes basically brings the JS compilation times to TS projects. So, recompilation took less than 1 second instead of 3 seconds in medium size project. The problem with async mode is that type-errors are reported after Webpack ends up recompilation as TypeScript could be slower than Babel. PR allows to emit files compiled by Babel immediately and then wait for TS and show type errors in terminal later. Also, if there was no compilation errors and any type error occurs, we trigger a hot-reload with new errors to show error overlay in browser. Also, I wanted to start a discussion about `skipLibCheck: false` option in default `tsconfig.json`. This makes recompilations really slow and we should consider to set it to `true` or at least give users a big warning to let them know that it could be really slow. The following video is showing the updated workflow with a forced 2.5 second delay for type-check to give you an idea how it works.  I'm pretty sure that PR needs some polishing and improvements but it should works as it is. Especially a "hack" with reloading the browser after type-check looks ugly to me. cc @brunolemos as he is an initiator of an original TypeScript PR. Should fix facebook#5820
Sass source map for dev
As part of the latest babel-plugin-macros [2.4.5 release](https://github.com/kentcdodds/babel-plugin-macros/releases/tag/v2.4.5), there was a small fix that went in that fixes a [bug](kentcdodds/babel-plugin-macros#100) specifying the `babelMacros` entry in `package.json` no longer working. This patch version increase should remedy the issue and allow specifying babel macro configuration in the `package.json` file again (as stated in the [user docs](https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md#config-experimental) of babel-plugin-macros)
* [docs] Warn about storing secrets in env vars Fixes facebook#5676 Co-Authored-By: Ian Schmitz <ianschmitz@gmail.com> * [docs] Add NOT to REACT_APP_SECRET_CODE Fixes facebook#5676 * [docs] Remove line breaks
* Add Jest typeahead plugin * Update jest-watch-typeahead to 0.2.1
* Update docs links to prefer HTTPS for supported domains * Fix existing typos
…ok#6451) * change class component to function component * Update packages/react-scripts/template/src/App.js Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com> * Update packages/react-scripts/template-typescript/src/App.tsx Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com>
compiler is not being reassigned, so we can use a const here
* Upgrade dependencies * Upgrade a couple missed deps * Run Prettier over codebase
* add command to add files to staging after eject * update console.log message * wrap git add in a try/catch block * return true & update log message * add test to check if files were staged * Fix check for staged files
* Add note about npx caching and link to facebook#6119 It is necessary to uninstall any version that was previously installed for the typescript flag to work when using npx. * Use proper casing for TypeScript Co-Authored-By: TaylorBriggs <TaylorBriggs@users.noreply.github.com>
* Add browserslist support to @babel/preset-env * Support @babel/polyfill in entry point
* Add Babel plug-in for Hooks; Add ESLint plug-in for Hooks (WIP) * Fix transform destructuring loose config * Add eslint-plugin-react-hooks to package.json * Fix package.json's * Fix eslint-plugin-react-hooks version * Fix package.json * Fix package.json * Add eslint-plugin-react-hooks to script package.json * Force array destructuring to work in loose mode only for known Hooks * Update based on feedback from PR * Add 'exhaustive-deps' lint rule * Bump eslint-plugin-react-hooks to stable version * Remove extraneous dependency from react-scripts
* Initial pass adding typescript-eslint * Add warning to shared rule set * Add documentation for setting up VSCode extension * Provide tsconfig path to typescript-eslitn
* Update to jest 24 * Add notice about pnpResolver.js * Formatting * Fix linting * Update to jest 24.1.0 * Update jest-pnp-resolver * Swap create-react-app params in e2e scripts * Add extraGlobals to supportedKeys * Bump jest to 24.3.1 * Bump jest to 24.4.0 * Bumb jest to 24.5.0 * Update template dependencies jest to 24.5.0 * Debug failing test * Remove jest-pnp-resolver * Remove console.log * Revert yarn.lock.cached
…#6662) Sync the `babel-eslint` version between react-scripts and eslint-config-react-app
…ion (facebook#6655) * Change app component declaration from arrow function to regular function * Change TypeScript template back to an arrow function
`url` was duplicated in `siteConfig.js`, both were the same value, so stripping one of them.
* Add AWS Amplify deployments to the CRA Docs * Fixed typos * added gif * GIF link * Update docusaurus/docs/deployment.md * create-react-app to Create React App * Update docusaurus/docs/deployment.md * Removed extra verbiage. * Removed GIF
…ook#6701) * Remove project property from @typescript-eslint/parser options The "project" property has a significant performance impact on linting, and none our rules currently need it. Fixes facebook#6661.
|
Will this work, or would you prefer to cherry pick commits into a new/cleaner PR? |
…ble-inlining-images' into 3437-environment-variable-to-disable-inlining-images
peterbe
merged commit ce4dfba
into
peterbe:3437-environment-variable-to-disable-inlining-images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the latest 100 commits from
facebook/masterand resolved the conflict in documentation