Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Floor null-safe #462

Merged
merged 60 commits into from
Mar 8, 2021
Merged

Make Floor null-safe #462

merged 60 commits into from
Mar 8, 2021

Conversation

vitusortner
Copy link
Collaborator

@vitusortner vitusortner commented Dec 23, 2020

This change list makes floor null-safe. We're now generating null-safe code but floor_generator's dependencies aren't exclusively null-safe. A later migration will need to take place (#504).

Dependencies not supporting null-safety yet:

  • build
  • build_config
  • build_test
  • dart_style
  • source_gen

Closes #375
Closes #338
Closes #502

vitusortner and others added 20 commits November 20, 2020 11:12
* Use provided iterable extensions where possible

* Get rid of dartx

* Get rid of list equality implementation
* Change ForeignKeyAction to enum in the generator (#359)

* Added support for WITH statements for DatabaseViews (#443)

* Documentation update on DateTimeConverter sample (#442)

* Make foreign key mapping null safe

Co-authored-by: mqus <8398165+mqus@users.noreply.github.com>
Co-authored-by: themadmrj <themadmrj@users.noreply.github.com>
Co-authored-by: Cássio Seffrin <cassioseffrin@gmail.com>
# Conflicts:
#	example/pubspec.lock
#	floor/pubspec.lock
#	floor/pubspec.yaml
#	floor_annotation/pubspec.lock
#	floor_annotation/pubspec.yaml
#	floor_generator/lib/misc/extension/dart_object_extension.dart
#	floor_generator/lib/misc/extension/foreign_key_action_extension.dart
#	floor_generator/lib/processor/entity_processor.dart
#	floor_generator/lib/processor/error/entity_processor_error.dart
#	floor_generator/lib/processor/insertion_method_processor.dart
#	floor_generator/lib/processor/update_method_processor.dart
#	floor_generator/lib/value_object/foreign_key.dart
#	floor_generator/pubspec.lock
#	floor_generator/pubspec.yaml
#	floor_generator/test/misc/extension/foreign_key_action_extension_test.dart
#	floor_generator/test/mocks.dart
#	floor_generator/test/value_object/entity_test.dart
#	floor_generator/test/value_object/foreign_key_test.dart
# Conflicts:
#	example/pubspec.lock
#	floor/pubspec.lock
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #462 (f63dc78) into develop (ee30e0a) will increase coverage by 0.19%.
The diff coverage is 90.34%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #462      +/-   ##
===========================================
+ Coverage    83.75%   83.94%   +0.19%     
===========================================
  Files           69       70       +1     
  Lines         1742     1744       +2     
===========================================
+ Hits          1459     1464       +5     
+ Misses         283      280       -3     
Flag Coverage Δ
floor 83.94% <90.34%> (+0.19%) ⬆️
floor_generator 83.22% <90.13%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
floor/lib/src/callback.dart 0.00% <ø> (ø)
...src/extension/on_conflict_strategy_extensions.dart 100.00% <ø> (ø)
...loor_generator/lib/misc/annotation_expression.dart 100.00% <ø> (ø)
...enerator/lib/misc/change_method_writer_helper.dart 100.00% <ø> (ø)
...b/misc/extension/foreign_key_action_extension.dart 85.71% <ø> (-14.29%) ⬇️
floor_generator/lib/misc/type_utils.dart 100.00% <ø> (ø)
floor_generator/lib/processor/dao_processor.dart 100.00% <ø> (ø)
...rator/lib/processor/deletion_method_processor.dart 77.77% <ø> (ø)
.../lib/processor/error/database_processor_error.dart 100.00% <ø> (ø)
...or/lib/processor/error/entity_processor_error.dart 16.12% <ø> (+0.50%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee30e0a...f63dc78. Read the comment docs.

@vitusortner vitusortner changed the title Make Floor null safe Make Floor null-safe Mar 8, 2021
@vitusortner vitusortner marked this pull request as ready for review March 8, 2021 17:54
@vitusortner vitusortner merged commit 296c783 into develop Mar 8, 2021
@vitusortner vitusortner deleted the nullsafety branch March 8, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to analyzer 1.1.0 Null safety Streams over single values do not emit null values
2 participants