-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Floor null-safe #462
Merged
Merged
Make Floor null-safe #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use provided iterable extensions where possible * Get rid of dartx * Get rid of list equality implementation
* Change ForeignKeyAction to enum in the generator (#359) * Added support for WITH statements for DatabaseViews (#443) * Documentation update on DateTimeConverter sample (#442) * Make foreign key mapping null safe Co-authored-by: mqus <8398165+mqus@users.noreply.github.com> Co-authored-by: themadmrj <themadmrj@users.noreply.github.com> Co-authored-by: Cássio Seffrin <cassioseffrin@gmail.com>
# Conflicts: # example/pubspec.lock # floor/pubspec.lock # floor/pubspec.yaml # floor_annotation/pubspec.lock # floor_annotation/pubspec.yaml # floor_generator/lib/misc/extension/dart_object_extension.dart # floor_generator/lib/misc/extension/foreign_key_action_extension.dart # floor_generator/lib/processor/entity_processor.dart # floor_generator/lib/processor/error/entity_processor_error.dart # floor_generator/lib/processor/insertion_method_processor.dart # floor_generator/lib/processor/update_method_processor.dart # floor_generator/lib/value_object/foreign_key.dart # floor_generator/pubspec.lock # floor_generator/pubspec.yaml # floor_generator/test/misc/extension/foreign_key_action_extension_test.dart # floor_generator/test/mocks.dart # floor_generator/test/value_object/entity_test.dart # floor_generator/test/value_object/foreign_key_test.dart
# Conflicts: # example/pubspec.lock # floor/pubspec.lock
Codecov Report
@@ Coverage Diff @@
## develop #462 +/- ##
===========================================
+ Coverage 83.75% 83.94% +0.19%
===========================================
Files 69 70 +1
Lines 1742 1744 +2
===========================================
+ Hits 1459 1464 +5
+ Misses 283 280 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
# Conflicts: # README.md # floor/README.md # floor/lib/src/sqflite_database_factory.dart
Co-authored-by: Dmytro Glynskyi <featzima@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change list makes floor null-safe. We're now generating null-safe code but floor_generator's dependencies aren't exclusively null-safe. A later migration will need to take place (#504).
Dependencies not supporting null-safety yet:
Closes #375
Closes #338
Closes #502