Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Revert "dump: retrieve ANSI_QUOTES from upstream (#909) (#929)" #1111

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

This reverts commit 3b16803. Because isolated dump unit auto discover will save ANSI_QUOTES into subtask config, which cause sync unit can't work

What is changed and how it works?

revert #929

Check List

Tests

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Sep 27, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 27, 2020
@csuzhangxc csuzhangxc added this to the v1.0.7 milestone Sep 27, 2020
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 28, 2020
@GMHDBJD GMHDBJD merged commit 0b34e18 into pingcap:release-1.0 Sep 28, 2020
@lance6716 lance6716 deleted the revert-dump-ansiquotes branch July 6, 2021 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants