Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dump: retrieve ANSI_QUOTES from upstream (#909) #929

Merged
merged 2 commits into from
Aug 26, 2020
Merged

dump: retrieve ANSI_QUOTES from upstream (#909) #929

merged 2 commits into from
Aug 26, 2020

Conversation

lance6716
Copy link
Collaborator

cherry-pick #909

What problem does this PR solve?

part of #907

What is changed and how it works?

retrieve ANSI_QUOTES from upstream, and change subtask config.

disable manually config EnableANSIQuotes of subtask

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Aug 25, 2020
GMHDBJD
GMHDBJD reviewed Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 25, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

csuzhangxc
csuzhangxc approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 26, 2020
@csuzhangxc csuzhangxc added this to the v1.0.7 milestone Aug 26, 2020
@lance6716 lance6716 merged commit 3b16803 into pingcap:release-1.0 Aug 26, 2020
@lance6716 lance6716 deleted the cp909-1 branch August 26, 2020 02:12
lance6716 added a commit to lance6716/dm that referenced this pull request Sep 27, 2020
@lance6716
Revert "dump: retrieve ANSI_QUOTES from upstream (pingcap#909) (pingc…
1126924 
…ap#929)"

This reverts commit 3b16803.
@lance6716 lance6716 mentioned this pull request Sep 27, 2020
Merged
GMHDBJD pushed a commit that referenced this pull request Sep 28, 2020
@lance6716
Revert "dump: retrieve ANSI_QUOTES from upstream (#909) (#929)" (#1111)
0b34e18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @csuzhangxc @GMHDBJD