Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dump: retrieve ANSI_QUOTES from upstream #909

Merged
merged 10 commits into from
Aug 25, 2020
Merged

dump: retrieve ANSI_QUOTES from upstream #909

merged 10 commits into from
Aug 25, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

part of #907

What is changed and how it works?

retrieve ANSI_QUOTES from upstream, and change subtask config.

disable manually config EnableANSIQuotes of subtask

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature labels Aug 20, 2020
@lance6716 lance6716 added the status/WIP This PR is still work in progress label Aug 20, 2020
@lance6716 lance6716 removed the status/WIP This PR is still work in progress label Aug 21, 2020
@lance6716 lance6716 mentioned this pull request Aug 21, 2020
Merged
@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Aug 21, 2020
GMHDBJD
GMHDBJD reviewed Aug 24, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 24, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 25, 2020
csuzhangxc
csuzhangxc reviewed Aug 25, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dumpling/dumpling.go Show resolved Hide resolved
csuzhangxc
csuzhangxc approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 25, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 merged commit 3966d17 into pingcap:master Aug 25, 2020
@ti-srebot
Copy link

cherry pick to release-1.0 failed

@lance6716 lance6716 deleted the ansi-quotes-2 branch August 25, 2020 07:45
@ti-srebot
Copy link

cherry pick to release-2.0 failed

lance6716 added a commit to lance6716/dm that referenced this pull request Aug 25, 2020
@lance6716
dump: retrieve ANSI_QUOTES from upstream (pingcap#909)
e1c45b9
@lance6716 lance6716 mentioned this pull request Aug 25, 2020
Merged
lance6716 added a commit to lance6716/dm that referenced this pull request Aug 25, 2020
@lance6716
dump: retrieve ANSI_QUOTES from upstream (pingcap#909)
c4a3cf5
@lance6716 lance6716 mentioned this pull request Aug 25, 2020
Merged
lance6716 added a commit that referenced this pull request Aug 26, 2020
@lance6716
dump: retrieve ANSI_QUOTES from upstream (#909) (#928)
c897557
lance6716 added a commit that referenced this pull request Aug 26, 2020
@lance6716
dump: retrieve ANSI_QUOTES from upstream (#909) (#929)
3b16803
@lance6716 lance6716 added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Aug 26, 2020
lance6716 added a commit to lance6716/dm that referenced this pull request Sep 27, 2020
@lance6716
Revert "dump: retrieve ANSI_QUOTES from upstream (pingcap#909) (pingc…
1126924 
…ap#929)"

This reverts commit 3b16803.
GMHDBJD pushed a commit that referenced this pull request Sep 28, 2020
@lance6716
Revert "dump: retrieve ANSI_QUOTES from upstream (#909) (#929)" (#1111)
0b34e18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
None yet
Milestone
v2.0.0 RC.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD