Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact arguments for Error #27

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Redact arguments for Error #27

merged 1 commit into from
Oct 15, 2020

Conversation

SunRunAway
Copy link

@SunRunAway SunRunAway commented Sep 27, 2020 •
edited
Loading

pingcap/tidb#18566

  • changes in "github.com/pingcap/errors"
    • redact errors in Error.GenWithStackByArgs & Error.FastGenByArgs
  • changes in "github.com/pingcap/parser"
    • define mysql.Message to bind redactArgs which means which arguments of the error need to be redacted with each error message
    • MySQLErrName should be defined with mysql.Message.
    • ErrClass.NewStd considers redactArgs
    • All errors uses ErrClass.NewStd or mysql.Message to consider error redaction
  • changes in "github.com/pingcap/tidb"
    • inherit ErrClass.NewStd
    • All errors uses ErrClass.NewStd or mysql.Message to consider error redaction

@SunRunAway
Copy link
Author

/cc @crazycs520

@SunRunAway
Copy link
Author

/cc @ichn-hu

crazycs520
crazycs520 reviewed Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ichn-hu
ichn-hu approved these changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu merged commit bbdd097 into pingcap:master Oct 15, 2020
@SunRunAway SunRunAway deleted the logredact branch October 15, 2020 11:12
This was referenced Oct 19, 2020
Merged
Merged
@lonng lonng mentioned this pull request Nov 10, 2020
Merged
@ti-srebot ti-srebot mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@ichn-hu ichn-hu ichn-hu approved these changes

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SunRunAway @lysu @crazycs520 @ichn-hu