*: redact arguments for Error (#1051) #1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1051
What problem does this PR solve?
part of pingcap/tidb#18566
What is changed and how it works?
Error.GenWithStackByArgs
&Error.FastGenByArgs
mysql.Message
to bindredactArgs
which means which arguments of the error need to be redacted with each error messageMySQLErrName
should be defined withmysql.Message
.ErrClass.NewStd
considersredactArgs
ErrClass.NewStd
ormysql.Message
to consider error redactionErrClass.NewStd
ErrClass.NewStd
ormysql.Message
to consider error redactionCheck List
Tests
Code changes