-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: redact arguments for Error #20436
Conversation
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests parser=pr/1051 |
1 similar comment
/run-all-tests parser=pr/1051 |
/run-unit-test |
/run-all-tests |
/run-sqllogic-test-1 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #21106 |
What problem does this PR solve?
Issue Number: part of #18566
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Error.GenWithStackByArgs
&Error.FastGenByArgs
mysql.Message
to bindredactArgs
which means which arguments of the error need to be redacted with each error messageMySQLErrName
should be defined withmysql.Message
.ErrClass.NewStd
considersredactArgs
ErrClass.NewStd
ormysql.Message
to consider error redactionErrClass.NewStd
ErrClass.NewStd
ormysql.Message
to consider error redactionHow it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
: To be addedCheck List
Tests
Case 1
log:
Case 2
Client 1:
Then start client 2:
log:
Release note
tidb_redact_log
to control showing the sensitive message in the log.