-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: fix creating partition tables fail in ANSI_QUOTES mode #35379
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion for extended test.
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3e10ae0618d9cdaabda613132999b41d95033fdf |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5e0e424
|
/run-all-tests |
/run-mysql-test |
/run-mysql-test |
1 similar comment
/run-mysql-test |
/run-mysql-test tidb-test=pr/1812 |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
* upstream/master: sessionctx: support encoding and decoding session variables (pingcap#35531) planner: add batch_point_get access object (pingcap#35230) sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown (pingcap#35491) *: add support for disabling noop variables (pingcap#35496) lightning: add store write limiter (pingcap#35193) expression: avoid padding 0 when implicitly cast to binary (pingcap#35053) types: fix creating partition tables fail in ANSI_QUOTES mode (pingcap#35379) executor: add the missed runtime stats when the index merge partial task returns 0 row (pingcap#35297) statistics: batch insert topn and bucket when saving table stats (pingcap#35326) parser: Add support for INTERVAL expr unit + expr (pingcap#30253) (pingcap#35390) config: add missing nodelay example (pingcap#35255) *: Introduce `OptimisticTxnContextProvider` for optimistic txn (pingcap#35131) statistics: fix panic when using wrong globalStats.Indices key (pingcap#35424) *: fix store token is up to the limit in test (pingcap#35374) *: enable more flaky and update bazel config (pingcap#35500) ddl: expose getPrimaryKey() as a public method of model.TableInfo (pingcap#35512) expression, util: add `KeyWithoutTrimRightSpace` for collator (pingcap#35475) infoschema: try on each PD member until one succeeds or all fail (pingcap#35285)
What problem does this PR solve?
Issue Number: close #35281, #24980
Problem Summary:
'2022-01-01 00:00:00'
is formatted as "2022-01-01 00:00:00" inbuildRangePartitionDefinitions
ParseSimpleExprWithTableInfo
creates the statementselect "2022-01-01 00:00:00"
to eval the value"2022-01-01 00:00:00"
is taken as an identifier sincesql_mode = 'ANSI_QUOTES'
.What is changed and how it works?
Format the string with single quotes, because single quotes always work.
In MySQL, even if
sql_mode
doesn't containANSI_QUOTES
, the expression still is single-quoted:Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.