Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown #35491

Merged
merged 13 commits into from
Jun 21, 2022
Merged

sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown #35491

merged 13 commits into from
Jun 21, 2022

Conversation

xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Jun 18, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35083

Problem Summary:

What is changed and how it works?

Set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xuyifangreeneyes xuyifangreeneyes requested a review from a team as a code owner June 18, 2022 13:50
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2022
@xuyifangreeneyes @morgo
Update sessionctx/variable/sysvar.go
617671c 
Co-authored-by: Morgan Tocker <tocker@gmail.com>
morgo
morgo reviewed Jun 19, 2022
View reviewed changes
sessionctx/variable/sysvar.go Outdated
s.AllowProjectionPushDown = TiDBOptOn(val)
return nil
}},
{Scope: ScopeSession, Name: TiDBOptAggPushDown, Value: BoolToOnOff(DefOptAggPushDown), Type: TypeBool, skipInit: true, SetSession: func(s *SessionVars, val string) error {
{Scope: ScopeSession, Name: TiDBOptAggPushDown, Value: BoolToOnOff(DefOptAggPushDown), Type: TypeBool, skipInit: false, SetSession: func(s *SessionVars, val string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one

Suggested change
{Scope: ScopeSession, Name: TiDBOptAggPushDown, Value: BoolToOnOff(DefOptAggPushDown), Type: TypeBool, skipInit: false, SetSession: func(s *SessionVars, val string) error {
{Scope: ScopeSession, Name: TiDBOptAggPushDown, Value: BoolToOnOff(DefOptAggPushDown), Type: TypeBool, SetSession: func(s *SessionVars, val string) error {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since DefOptAggPushDown is false, TiDBOptAggPushDown doesn't have the problem like #35083 even if skipInit is true. Maybe we can just keep it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only known required use cases for skipInit are:

  1. old-style INSTANCE scoped variables (which use SESSION). There are only 2 of these left: TiDBLogFileMaxDays and TiDBConfig should be ScopeInstance #35190
  2. when you set the charset, it automatically sets the default collation for that charset.

We can use a workaround to check if it is a user issuing a Set statement for (2), so eventually we should be able to remove skipInit completely. The problem is because it exists, everyone keeps using it incorrectly (adding new cases that skipInit).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipInit of TiDBOptAggPushDown is removed now.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2022
@xuyifangreeneyes xuyifangreeneyes changed the title sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown sessionctx: set skipInit false for TiDBOptProjectionPushDown Jun 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 19, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1d4d7fac7a7d507d8ae21aa0793e53a7e9f3a2e5

@xuyifangreeneyes xuyifangreeneyes requested a review from morgo June 19, 2022 07:37
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 19, 2022
@xuyifangreeneyes xuyifangreeneyes changed the title sessionctx: set skipInit false for TiDBOptProjectionPushDown sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown Jun 20, 2022
@qw4990
Copy link
Contributor

qw4990 commented Jun 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f42d5f2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@xuyifangreeneyes
Copy link
Contributor Author

/run-build

@xuyifangreeneyes
Copy link
Contributor Author

/run-unit-test

@xuyifangreeneyes
Copy link
Contributor Author

/run-mysql-test

@xuyifangreeneyes
Copy link
Contributor Author

/run-unit-test

@hawkingrei
Copy link
Member

@XuHuaiyu @bb7133 PTAL

bb7133
bb7133 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jun 21, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit f89466d into pingcap:master Jun 21, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 21, 2022
@xuyifangreeneyes @ti-srebot
cherry pick pingcap#35491 to release-6.1
4f377b3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 21, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35594

morgo added a commit to morgo/tidb that referenced this pull request Jun 28, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into kill-ddl
afde8a8 
* upstream/master:
  sessionctx: support encoding and decoding session variables (pingcap#35531)
  planner: add batch_point_get access object (pingcap#35230)
  sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown (pingcap#35491)
  *: add support for disabling noop variables (pingcap#35496)
  lightning: add store write limiter (pingcap#35193)
  expression: avoid padding 0 when implicitly cast to binary (pingcap#35053)
  types: fix creating partition tables fail in ANSI_QUOTES mode (pingcap#35379)
  executor: add the missed runtime stats when the index merge partial task returns 0 row (pingcap#35297)
  statistics: batch insert topn and bucket when saving table stats (pingcap#35326)
  parser: Add support for INTERVAL expr unit + expr (pingcap#30253) (pingcap#35390)
  config: add missing nodelay example (pingcap#35255)
  *: Introduce `OptimisticTxnContextProvider` for optimistic txn (pingcap#35131)
  statistics: fix panic when using wrong globalStats.Indices key (pingcap#35424)
  *: fix store token is up to the limit in test (pingcap#35374)
  *: enable more flaky and update bazel config (pingcap#35500)
  ddl: expose getPrimaryKey() as a public method of model.TableInfo (pingcap#35512)
  expression, util: add `KeyWithoutTrimRightSpace` for collator (pingcap#35475)
  infoschema: try on each PD member until one succeeds or all fail (pingcap#35285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb_opt_projection_push_down doesn't take effect
8 participants
@xuyifangreeneyes @ti-chi-bot @sre-bot @qw4990 @hawkingrei @bb7133 @ti-srebot @morgo