Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: make prepare analyze killed globally instead of query quota #44352

Merged
merged 3 commits into from
Jun 2, 2023
Merged

executor: make prepare analyze killed globally instead of query quota #44352

merged 3 commits into from
Jun 2, 2023

Conversation

chrysan
Copy link
Contributor

@chrysan chrysan commented Jun 2, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44320 & #40946

Problem Summary:
For now, prepare stmt from "analyze table t"; execute stmt; is not recognized as an analyze statement and is not managed by global memory quota instead of query memory quota.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 2, 2023
@chrysan chrysan requested review from XuHuaiyu and yibin87 June 2, 2023 05:18
chrysan
chrysan commented Jun 2, 2023
View reviewed changes
util/memory/tracker.go
bytesConsumed int64 // Consumed bytes.
bytesReleased int64 // Released bytes.
maxConsumed atomicutil.Int64 // max number of bytes consumed during execution.
SessionID atomicutil.Uint64 // SessionID indicates the sessionID the tracker is bound.
Copy link
Contributor Author

@chrysan chrysan Jun 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to fix race. cc @XuHuaiyu

yibin87
yibin87 reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，but not reviewer yet.

@chrysan chrysan requested review from hawkingrei and qw4990 June 2, 2023 07:10
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2023
@chrysan chrysan requested a review from wshwsh12 June 2, 2023 07:24
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e2284bb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
@hawkingrei
Copy link
Member

/retest

@chrysan chrysan mentioned this pull request Jun 2, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot merged commit d5861ef into pingcap:master Jun 2, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44367.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 2, 2023
@chrysan @ti-chi-bot
This is an automated cherry-pick of pingcap#44352
026b7e3 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44368.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 5, 2023
@ti-chi-bot
executor: make prepare analyze killed globally instead of query quota (…
b768eb5 
…#44352) (#44367)

ref #40946, close #44320
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
@ti-chi-bot
executor: make prepare analyze killed globally instead of query quota (…
b96ce5c 
…#44352) (#44368)

close #44320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@qw4990 qw4990 qw4990 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepared "analyze table" statement cancelled due to exceeds "tidb_mem_quota_query"
6 participants
@chrysan @hawkingrei @ti-chi-bot @qw4990 @XuHuaiyu @yibin87