Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make prepare analyze killed globally instead of query quota | tidb-test=pr/2145 #44363

Conversation

chrysan
Copy link
Contributor

@chrysan chrysan commented Jun 2, 2023

What problem does this PR solve?

Issue Number: ref #44320

Problem Summary:
For now, prepare stmt from "analyze table t"; execute stmt; is not recognized as an analyze statement and is not managed by global memory quota instead of query memory quota.
Cherry-pick of #44352

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2023
@chrysan chrysan requested review from yibin87, hawkingrei and qw4990 June 2, 2023 08:37
hawkingrei
hawkingrei previously approved these changes Jun 2, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2023
qw4990
qw4990 previously approved these changes Jun 2, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2023
@chrysan chrysan dismissed stale reviews from qw4990 and hawkingrei via e7502b7 June 2, 2023 09:02
@chrysan
Copy link
Contributor Author

chrysan commented Jun 2, 2023

/test mysql-test

@chrysan chrysan changed the title executor: make prepare analyze killed globally instead of query quota executor: make prepare analyze killed globally instead of query quota | tidb-test=pr/2145 Jun 2, 2023
@chrysan
Copy link
Contributor Author

chrysan commented Jun 2, 2023

/test mysql-test

@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/merge

1 similar comment
@chrysan
Copy link
Contributor Author

chrysan commented Jun 5, 2023

/merge

@chrysan
Copy link
Contributor Author

chrysan commented Jun 5, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@xuyifangreeneyes: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrysan
Copy link
Contributor Author

chrysan commented Jun 5, 2023

/merge

@chrysan
Copy link
Contributor Author

chrysan commented Jun 5, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@lance6716: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrysan, hawkingrei, lance6716, xuyifangreeneyes

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrysan chrysan removed the request for review from yibin87 June 5, 2023 03:43
@ti-chi-bot ti-chi-bot bot merged commit d35d315 into pingcap:release-6.5-20230425-v6.5.2 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants