Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageFile in PageStorage V2 maybe truncate at restart #5385

Closed
lidezhu opened this issue Jul 15, 2022 · 0 comments · Fixed by #5384
Closed

PageFile in PageStorage V2 maybe truncate at restart #5385

lidezhu opened this issue Jul 15, 2022 · 0 comments · Fixed by #5384
Assignees
@lidezhu
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. component/storage severity/major type/bug The issue is confirmed as a bug.

Comments

@lidezhu
Copy link
Contributor

lidezhu commented Jul 15, 2022 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

After change some hardcode config for ps v2 and patch tiflash, it print the following log:
[2022/07/15 13:50:47.825 +08:00] [DEBUG] [PageStorage.cpp:457] ["PageStorage:RegionPersister create new PageFile_1_0 for write [path=/data1/lidezhu/tidb-data/tiflash-9089/kvstore/]"] [thread_id=1]
But PageFile_1_0 is a page file that already has data which make data in PageFile_1_0 lost.

Note that in real scenario, this has very little possibility to happen.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)
@lidezhu lidezhu added type/bug The issue is confirmed as a bug. component/storage severity/moderate labels Jul 15, 2022
@lidezhu lidezhu mentioned this issue Jul 15, 2022
Merged
12 tasks
@lidezhu lidezhu added affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. labels Jul 15, 2022
ti-chi-bot pushed a commit that referenced this issue Jul 15, 2022
@lidezhu
fix pagestorage v2 restore (#5384)
f7be362 
close #5385
This was referenced Jul 15, 2022
Closed
Merged
Closed
Closed
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this issue Jul 15, 2022
@lidezhu @ti-chi-bot
fix pagestorage v2 restore (pingcap#5384)
3005ef7 
close pingcap#5385
This was referenced Jul 15, 2022
Closed
Merged
ti-chi-bot added a commit that referenced this issue Aug 17, 2022
@ti-chi-bot
fix pagestorage v2 restore (#5384) (#5393)
3fa0eff 
close #5385
ti-chi-bot added a commit that referenced this issue Dec 9, 2022
@ti-chi-bot
fix pagestorage v2 restore (#5384) (#5388)
5fd8d45 
close #5385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidezhu lidezhu

Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. component/storage severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix pagestorage v2 restore lidezhu/tics
3 participants
@flowbehappy @lidezhu @ti-chi-bot