fix pagestorage v2 restore

[lidezhu]

What problem does this PR solve?

Issue Number: close #5385

Problem Summary: When restart, ps v2 will try to reuse old page file for writing. But if no file can be used for writing, it will create new page file. But the file id of the new page file is determined by the max file id in writing page file set which is empty now. And it will create PageFile_1_0 in this case for writing which may override previous data.

What is changed and how it works?

Make sure new page file id is larger than all current page files at restart.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

LGTM

[ti-chi-bot]

@lidezhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[lidezhu]

/run-unit-test

[sre-bot]

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageStorage.cpp                      553               191    65.46%          39                 5    87.18%         952               211    77.84%         370               169    54.32%
PageStorage.h                         49                13    73.47%          20                 3    85.00%          48                 4    91.67%          22                13    40.91%
tests/gtest_page_storage.cpp        4916              1005    79.56%          33                 2    93.94%        1070                 5    99.53%        1514               721    52.38%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               5518              1209    78.09%          92                10    89.13%        2070               220    89.37%        1906               903    52.62%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18594      9573             48.52%    211802  96369        54.50%

full coverage report (for internal network access only)

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5387.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5388.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5389.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5390.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5391.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5392.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5393.