-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pagestorage v2 restore (#5384) #5389
fix pagestorage v2 restore (#5384) #5389
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/rebuild |
This pull request is closed because its related version has closed automatic cherry-picking. https://prow.tidb.net/command-help#cherrypick |
This is an automated cherry-pick of #5384
What problem does this PR solve?
Issue Number: close #5385
Problem Summary: When restart, ps v2 will try to reuse old page file for writing. But if no file can be used for writing, it will create new page file. But the file id of the new page file is determined by the max file id in writing page file set which is empty now. And it will create
PageFile_1_0
in this case for writing which may override previous data.What is changed and how it works?
Make sure new page file id is larger than all current page files at restart.
Check List
Tests
Side effects
Documentation
Release note