syncer(dm): use an early location to reset binlog and open safemode #3860

lance6716 · 2021-12-13T12:50:49Z

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/3487 for release-5.3
https://github.com/pingcap/ticdc/issues/3711 of master branch need a better solution

What is changed and how it works?

we use globalCheckpoint which is a correct-but-early location to reset binlog streamer, and open one transaction safemode

add a half of an integration test back

Check List

Tests

Integration test

Code changes

Side effects

Related changes

Release note

Fix a bug of data loss when DM does finer grained retry

ti-chi-bot · 2021-12-13T12:50:50Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

glorv
lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov-commenter · 2021-12-13T13:12:00Z

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@961af87). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.3      #3860   +/-   ##
================================================
  Coverage               ?   56.6504%           
================================================
  Files                  ?        212           
  Lines                  ?      22946           
  Branches               ?          0           
================================================
  Hits                   ?      12999           
  Misses                 ?       8627           
  Partials               ?       1320

lance6716 · 2021-12-14T02:05:47Z

/run-all-tests

glorv · 2021-12-15T08:20:45Z

dm/syncer/syncer.go

 				if err != nil {
 					return err
 				}
 				log.L().Info("reset replication binlog puller", zap.Any("pos", s.checkpoint.GlobalPoint()))
+				_ = s.safeMode.Add(tctx, 1)


How about use a local variable like inFinerRetry to record this temporary safe-mode

safeMode: s.safeMode.Enable() || retrySafeMode,

glorv · 2021-12-15T08:24:39Z

dm/syncer/syncer.go

@@ -1621,11 +1632,13 @@ func (s *Syncer) Run(ctx context.Context) (err error) {

 			if s.streamerController.CanRetry(err) {
 				// lastLocation is the last finished GTID
-				err = s.streamerController.ResetReplicationSyncer(tctx, lastLocation)
+				err = s.streamerController.ResetReplicationSyncer(tctx, s.checkpoint.GlobalPoint())


If this retry is occurred at sharding-resyc phase, enable safe-mode for one transaction is not enough because the start point may be reset to the very beginning point. But since safe-mode is enable in the full sharding-resync phase this is ok. Maybe we can add a comment about this here.

What does safe-mode is enable in the full sharding-resync phase means? To me this is a problem.

we will open safemode when there's an unsynced sharding table

https://github.com/pingcap/ticdc/blob/d381504a9fc3e5e6615e17627c424ec5bd17b0b4/dm/syncer/syncer.go#L2680

https://github.com/pingcap/ticdc/blob/d381504a9fc3e5e6615e17627c424ec5bd17b0b4/dm/syncer/syncer.go#L2708

please help check it

Looks good to me

lichunzhu

Rest LGTM

lichunzhu · 2021-12-15T09:04:45Z

dm/syncer/syncer.go

@@ -1621,11 +1632,13 @@ func (s *Syncer) Run(ctx context.Context) (err error) {

 			if s.streamerController.CanRetry(err) {
 				// lastLocation is the last finished GTID
-				err = s.streamerController.ResetReplicationSyncer(tctx, lastLocation)
+				err = s.streamerController.ResetReplicationSyncer(tctx, s.checkpoint.GlobalPoint())


What does safe-mode is enable in the full sharding-resync phase means? To me this is a problem.

lance6716 · 2021-12-21T03:27:14Z

ping @lichunzhu @glorv

glorv

LGTM

lance6716 · 2021-12-21T05:41:47Z

/cc @GMHDBJD

lance6716 · 2021-12-22T02:15:56Z

/assign @nongfushanquan

lance6716 · 2021-12-22T04:15:53Z

/merge

ti-chi-bot · 2021-12-22T04:15:56Z

This pull request has been accepted and is ready to merge.

Commit hash: 28ef93a

ti-chi-bot · 2021-12-22T04:16:09Z

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lance6716 · 2021-12-22T05:50:22Z

/run-leak-test

…ingcap#3860)

* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ * address comments * add comments for exported functions * fix the compiling problem * workerpool: limit the rate to output deadlock warning (#3775) (#3795) * tests(ticdc): set up the sync diff output directory correctly (#3725) (#3741) * relay(dm): use binlog name comparison (#3710) (#3712) * dm/load: fix concurrent call Loader.Status (#3459) (#3468) * cdc/sorter: make unified sorter cgroup aware (#3436) (#3439) * tz (ticdc): fix timezone error (#3887) (#3906) * pkg,cdc: do not use log package (#3902) (#3940) * *: rename repo from pingcap/ticdc to pingcap/tiflow (#3959) * http_*: add log for http api and refine the err handle logic (#2997) (#3307) * etcd_worker: batch etcd patch (#3277) (#3389) * http_api (ticdc): check --cert-allowed-cn before add server common name (#3628) (#3882) * kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3663) * owner: fix owner tick block http request (#3490) (#3530) * dm/syncer: use downstream PK/UK to generate DML (#3168) (#3256) * dep(dm): update go-mysql (#3914) (#3934) * dm/syncer: multiple rows use downstream schema (#3308) (#3953) * errorutil,sink,syncer: add errorutil to handle ignorable error (#3264) (#3995) * dm/worker: don't exit when failed to read checkpoint in relay (#3345) (#4005) * syncer(dm): use an early location to reset binlog and open safemode (#3860) * ticdc/owner: Fix ddl special comment syntax error (#3845) (#3978) * dm/scheduler: fix inconsistent of relay status (#3474) (#4009) * owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4016) * config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3783) * sink(ticdc): cherry pick sink bug fix to release 5.3 (#4083) * master(dm): clean and treat invalid load task (#4004) (#4145) * loader: fix wrong progress in query-status for loader (#4093) (#4143) close #3252 * ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4028) * dm: load table structure from dump files (#3295) (#4163) * compactor: fix duplicate entry in safemode (#3432) (#3434) (#4088) * kv(ticdc): reduce eventfeed rate limited log (#4072) (#4111) close #4006 * metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4104) * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * retry(dm): align with tidb latest error message (#4172) (#4254) close #4159, close #4246 * owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) (#3865) * redolog: add a precleanup process when s3 enable (#3525) (#3878) * ddl(dm): make skipped ddl pass `SplitDDL()` (#4176) (#4227) close #4173 * cdc/sink: remove Initialize method from the sink interface (#3682) (#3765) Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> * http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4123) close #3840 * sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4099) close #4055 * cdc/sink: adjust kafka initialization logic (#3192) (#4162) * try fix conflicts. * This is an automated cherry-pick of #4192 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflicts. * fix conflicts. Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com> Co-authored-by: amyangfei <yangfei@pingcap.com> Co-authored-by: lance6716 <lance6716@gmail.com> Co-authored-by: sdojjy <sdojjy@qq.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>

syncer(dm): use an early location to reset binlog and open safemode

de0f878

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2021

lance6716 added the area/dm Issues or PRs related to DM. label Dec 13, 2021

glorv reviewed Dec 15, 2021

View reviewed changes

lichunzhu reviewed Dec 15, 2021

View reviewed changes

lance6716 added 3 commits December 15, 2021 19:38

address comment

73386ec

Merge branch 'release-5.3' into manually-fix

b146ba7

Merge branch 'release-5.3' into manually-fix

28ef93a

glorv approved these changes Dec 21, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2021

ti-chi-bot requested a review from GMHDBJD December 21, 2021 05:41

lichunzhu approved these changes Dec 21, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2021

ti-chi-bot assigned nongfushanquan Dec 22, 2021

nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 22, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2021

Merge branch 'release-5.3' into manually-fix

882d5f4

ti-chi-bot merged commit 167963a into pingcap:release-5.3 Dec 22, 2021

This was referenced Dec 24, 2021

relay, syncer(dm): stricter GTID check when retry replication (#3496) #3754

Closed

DM use a wrong GTID set when do finer grained retry #3711

Closed

3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 13, 2022

syncer(dm): use an early location to reset binlog and open safemode (p…

5a9e78f

…ingcap#3860)

purelind added this to the v5.3.1 milestone Feb 24, 2022

lance6716 deleted the manually-fix branch October 13, 2022 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

syncer(dm): use an early location to reset binlog and open safemode #3860

syncer(dm): use an early location to reset binlog and open safemode #3860

lance6716 commented Dec 13, 2021 •

edited

Loading

ti-chi-bot commented Dec 13, 2021 •

edited

Loading

codecov-commenter commented Dec 13, 2021

lance6716 commented Dec 14, 2021

glorv Dec 15, 2021 •

edited

Loading

glorv Dec 15, 2021

lichunzhu Dec 15, 2021

lance6716 Dec 15, 2021 •

edited

Loading

lichunzhu Dec 21, 2021

lichunzhu left a comment

lichunzhu Dec 15, 2021

lance6716 commented Dec 21, 2021

glorv left a comment

lance6716 commented Dec 21, 2021

lance6716 commented Dec 22, 2021

lance6716 commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

lance6716 commented Dec 22, 2021

syncer(dm): use an early location to reset binlog and open safemode #3860

syncer(dm): use an early location to reset binlog and open safemode #3860

Conversation

lance6716 commented Dec 13, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Dec 13, 2021 • edited Loading

codecov-commenter commented Dec 13, 2021

Codecov Report

lance6716 commented Dec 14, 2021

glorv Dec 15, 2021 • edited Loading

Choose a reason for hiding this comment

glorv Dec 15, 2021

Choose a reason for hiding this comment

lichunzhu Dec 15, 2021

Choose a reason for hiding this comment

lance6716 Dec 15, 2021 • edited Loading

Choose a reason for hiding this comment

lichunzhu Dec 21, 2021

Choose a reason for hiding this comment

lichunzhu left a comment

Choose a reason for hiding this comment

lichunzhu Dec 15, 2021

Choose a reason for hiding this comment

lance6716 commented Dec 21, 2021

glorv left a comment

Choose a reason for hiding this comment

lance6716 commented Dec 21, 2021

lance6716 commented Dec 22, 2021

lance6716 commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

lance6716 commented Dec 22, 2021

lance6716 commented Dec 13, 2021 •

edited

Loading

ti-chi-bot commented Dec 13, 2021 •

edited

Loading

glorv Dec 15, 2021 •

edited

Loading

lance6716 Dec 15, 2021 •

edited

Loading