Replace shell's proxy with new gRPC backed proxy #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
force-pushed
the
grpcproxy
branch
from
1da84d0 to
34a851f
Compare
iheanyi
approved these changes
Nov 27, 2023
This was referenced Nov 27, 2023
fatih
reviewed
Nov 28, 2023
| UpstreamAddr: cfg.UpstreamAddr, | ||
| Authorization: auth.NewBasicAuth(cfg.Username, cfg.Password), | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think we need this extra package for constructing the server type. I would include this only if we reuse it in multiple places. Otherwise it'll just create an additional abstraction with no immediate benefits.
There was a problem hiding this comment.
It's reused in subsequent PRs. I just didn't want to do them all in one big one. So if this were the only implementation, I'd agree, but it was intended to be shared by every use case of sql-proxy.
There was a problem hiding this comment.
Gotcha, thanks for the clarification.
mattrobenolt
force-pushed
the
grpcproxy
branch
2 times, most recently
from
6d347a7 to
0cb7d4c
Compare
fatih
approved these changes
Nov 28, 2023
mattrobenolt
force-pushed
the
grpcproxy
branch
from
0cb7d4c to
584394c
Compare
mattrobenolt
force-pushed
the
grpcproxy
branch
from
584394c to
3d284fd
Compare
licensed was marking them as `other`. Manually reviewed each.
mattrobenolt
added a commit
that referenced
this pull request
Dec 6, 2023
As it turns out, bringing in a dependency on vitess is going to be borderline impossible into our CLI since it completely restricts what environments we can compile to. Specifically, vitess has 0 support for anything Windows currently. So this will have to come back in a reimagined way. Revert "database/restore: port to using psdbproxy (#761)" This reverts commit 33bb6bd. Revert "database/dump: port to using psdbproxy (#760)" This reverts commit 067d436. Revert "Replace shell's proxy with new gRPC backed proxy (#759)" This reverts commit 3884029.
mattrobenolt
added a commit
that referenced
this pull request
Dec 6, 2023
As it turns out, bringing in a dependency on vitess is going to be borderline impossible into our CLI since it completely restricts what environments we can compile to. Specifically, vitess has 0 support for anything Windows currently. So this will have to come back in a reimagined way. Revert "database/restore: port to using psdbproxy (#761)" This reverts commit 33bb6bd. Revert "database/dump: port to using psdbproxy (#760)" This reverts commit 067d436. Revert "Replace shell's proxy with new gRPC backed proxy (#759)" This reverts commit 3884029.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the sql-proxy implementation with the new psdbproxy implementation.
Swapping in pscale shell is the first on the chopping block but wanted to get this integrated into the codebase first to serve as the base for the other uses of sql-proxy.
In summary, this replaces the certificate based sql-proxy, which relies on deprecated infrastructure, with a new HTTP based proxy.
This new HTTP-based proxy will be more resilient to network issues as well as acting as a connection pooler for local mysql connections.
This relies on open sourcing the
planetscale/psdbproxyrepo yet.