Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/restore: port to using psdbproxy #761

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

mattrobenolt
Copy link
Member

Depends on #759

Base automatically changed from pscale-dump to main December 6, 2023 20:58
@mattrobenolt mattrobenolt enabled auto-merge (squash) December 6, 2023 20:59
@mattrobenolt mattrobenolt merged commit 33bb6bd into main Dec 6, 2023
1 check passed
@mattrobenolt mattrobenolt deleted the pscale-restore branch December 6, 2023 21:00
mattrobenolt added a commit that referenced this pull request Dec 6, 2023
As it turns out, bringing in a dependency on vitess is going to be
borderline impossible into our CLI since it completely restricts what
environments we can compile to.

Specifically, vitess has 0 support for anything Windows currently.

So this will have to come back in a reimagined way.

Revert "database/restore: port to using psdbproxy (#761)"

This reverts commit 33bb6bd.

Revert "database/dump: port to using psdbproxy (#760)"

This reverts commit 067d436.

Revert "Replace shell's proxy with new gRPC backed proxy (#759)"

This reverts commit 3884029.
mattrobenolt added a commit that referenced this pull request Dec 6, 2023
As it turns out, bringing in a dependency on vitess is going to be
borderline impossible into our CLI since it completely restricts what
environments we can compile to.

Specifically, vitess has 0 support for anything Windows currently.

So this will have to come back in a reimagined way.

Revert "database/restore: port to using psdbproxy (#761)"

This reverts commit 33bb6bd.

Revert "database/dump: port to using psdbproxy (#760)"

This reverts commit 067d436.

Revert "Replace shell's proxy with new gRPC backed proxy (#759)"

This reverts commit 3884029.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants