database/dump: port to using psdbproxy #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iheanyi
approved these changes
Nov 27, 2023
mattrobenolt
commented
Nov 27, 2023
| @@ -46,6 +48,8 @@ func DumpCmd(ch *cmdutil.Helper) *cobra.Command { | |||
| "", "Optionally target a specific keyspace to be dumped. Useful for sharded databases.") | |||
| cmd.PersistentFlags().StringVar(&f.localAddr, "local-addr", | |||
| "", "Local address to bind and listen for connections. By default the proxy binds to 127.0.0.1 with a random port.") | |||
| cmd.PersistentFlags().StringVar(&f.remoteAddr, "remote-addr", "", | |||
There was a problem hiding this comment.
Added -remote-addr like shell had. Good option to have so something like -remote-addr=us-west.connect.psdb.cloud could be used or something.
mattrobenolt
force-pushed
the
grpcproxy
branch
2 times, most recently
from
6d347a7 to
0cb7d4c
Compare
mattrobenolt
force-pushed
the
pscale-dump
branch
from
890eea4 to
e9aed1c
Compare
mattrobenolt
force-pushed
the
grpcproxy
branch
2 times, most recently
from
584394c to
3d284fd
Compare
mattrobenolt
force-pushed
the
pscale-dump
branch
from
e9aed1c to
ab7c455
Compare
mattrobenolt
force-pushed
the
pscale-dump
branch
from
ab7c455 to
69b58dd
Compare
mattrobenolt
added a commit
that referenced
this pull request
Dec 6, 2023
As it turns out, bringing in a dependency on vitess is going to be borderline impossible into our CLI since it completely restricts what environments we can compile to. Specifically, vitess has 0 support for anything Windows currently. So this will have to come back in a reimagined way. Revert "database/restore: port to using psdbproxy (#761)" This reverts commit 33bb6bd. Revert "database/dump: port to using psdbproxy (#760)" This reverts commit 067d436. Revert "Replace shell's proxy with new gRPC backed proxy (#759)" This reverts commit 3884029.
mattrobenolt
added a commit
that referenced
this pull request
Dec 6, 2023
As it turns out, bringing in a dependency on vitess is going to be borderline impossible into our CLI since it completely restricts what environments we can compile to. Specifically, vitess has 0 support for anything Windows currently. So this will have to come back in a reimagined way. Revert "database/restore: port to using psdbproxy (#761)" This reverts commit 33bb6bd. Revert "database/dump: port to using psdbproxy (#760)" This reverts commit 067d436. Revert "Replace shell's proxy with new gRPC backed proxy (#759)" This reverts commit 3884029.
dbussink
pushed a commit
that referenced
this pull request
Dec 19, 2023
dbussink
pushed a commit
that referenced
this pull request
Jan 3, 2024
dbussink
pushed a commit
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #759