Rewrite of the colour skill & refactoring of difficulty calculation within osu!taiko #19566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repetition is found.
This addresses recent player unsatisfaction with converts being underweighted.
|
SR/PP sheet added to OP. |
|
Closing this due to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen of #19184.
This PR aims to get all the major refactoring out of the way, and with the addition of the rewritten colour skill. Apologies for the large size of the PR, as everything is much too intertwined to properly split this PR. This should be the last PR of its out of proportion scale.
Full rewrite on the colour skill based on information density. See here for a more detailed explanation.
Adjusted weight of each skill. Rhythm is intentionally weighted lower due to it not being worked on yet.
Changes to taiko difficulty hit object to incorporate evaluators.
Ported stamina and colour into stateless evaluators.
Changed stamina speed bonus to be 1 / interval based.
Removed separated ratings for final SR Calculation.
Moved locally combined difficulty (strain peaks) into the peaks skill, all other skills are now under this.
Changed locally combined difficulty to use 2-norm to combine stamina and colour, and a 1.5-norm to combine that with rhythm.
Addition of data directories, which will be used in future references per skill.
Addition of per skill pre-processing, to clean up clutter.
SR/PP sheet versus
masterprior to #19181 : https://docs.google.com/spreadsheets/d/1bSE9UGLG50U1r8Ih90A9kheGbPDrDx1sXtmNW9VCdIg/editAs of smoogipoo@61d2b8e