Rewrite of the colour skill & refactoring of difficulty calculation within osu!taiko #19571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repetition is found.
I read through this thinking "why doesn't Previous get assigned to currentEncoding here? But it's because the initializer runs right after the ctor and before the "method" returns. So really there's 3 operations running on one line here - ctor, init, and assignment.
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/TaikoDifficultyHitObject.cs
Outdated
Show resolved
Hide resolved
smoogipoo
previously approved these changes
Aug 15, 2022
|
I'm doing one last sheet generation to make sure I didn't break anything here. The taiko committee previously had approvals on this and the code looks fine to me, without diving into the maths. Can I get a quick second look over this from one of you @peppy @bdach ? I intend to get this out very soon. |
bdach
reviewed
Aug 15, 2022
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/TaikoColourDifficultyPreprocessor.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/Data/MonoEncoding.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/Data/ColourEncoding.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/Data/ColourEncoding.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/Data/ColourEncoding.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/Data/CoupledColourEncoding.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/Data/CoupledColourEncoding.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/Data/CoupledColourEncoding.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/TaikoColourDifficultyPreprocessor.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ColourEvaluator.cs
Outdated
Show resolved
Hide resolved
|
With the latest changes the diff looks much better to me. Save for one unaddressed review comment this looks pretty much ready as far as I'm concerned. |
bdach
approved these changes
Aug 24, 2022
smoogipoo
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen of #19184 and #19566
Apologies for the clutter, I have to reopen this from my personal repository due to the
Allow edits and access to secrets by maintainersoption not being available to me or Lawtrohux when opening from the taiko-pp-committee repository.This PR aims to get all the major refactoring out of the way, and with the addition of the rewritten colour skill. Apologies for the large size of the PR, as everything is much too intertwined to properly split this PR. This should be the last PR of its out of proportion scale.
Full rewrite on the colour skill based on information density. See here for a more detailed explanation.
SR/PP sheet versus master prior to #19181 : https://docs.google.com/spreadsheets/d/1V27Jiyg0sD7zQuVoklkbW10fPpIMVqXEkblZkolyDD8/edit
As of fb9bb2d