Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve perf #3956

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Improve perf #3956

merged 2 commits into from
Mar 31, 2023

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 30, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +2% (-4.36ms - +2.29ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -3% - +4% (-1.25ms - +2.03ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-20.85ms - +19.35ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +3% (-1.04ms - +0.93ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +3% (-1.20ms - +2.98ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +2% (-2.27ms - +0.93ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -3% - +0% (-0.10ms - +0.01ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -1% - +1% (-0.61ms - +0.38ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.03ms - +0.02ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.04ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +9% (-0.06ms - +1.22ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master137.01ms - 141.61ms-unsure 🔍
-2% - +3%
-2.29ms - +4.36ms		unsure 🔍
-2% - +3%
-2.72ms - +4.00ms
preact-local135.87ms - 140.67msunsure 🔍
-3% - +2%
-4.36ms - +2.29ms		-unsure 🔍
-3% - +2%
-3.83ms - +3.04ms
preact-hooks136.21ms - 141.12msunsure 🔍
-3% - +2%
-4.00ms - +2.72ms		unsure 🔍
-2% - +3%
-3.04ms - +3.83ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master15.51ms - 15.55ms-unsure 🔍
-0% - +0%
-0.02ms - +0.03ms		unsure 🔍
-0% - -0%
-0.06ms - -0.01ms
preact-local15.51ms - 15.55msunsure 🔍
-0% - +0%
-0.03ms - +0.02ms		-unsure 🔍
-0% - -0%
-0.07ms - -0.02ms
preact-hooks15.55ms - 15.59msunsure 🔍
+0% - +0%
+0.01ms - +0.06ms		unsure 🔍
+0% - +0%
+0.02ms - +0.07ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master45.21ms - 46.48ms-unsure 🔍
-1% - +3%
-0.56ms - +1.34ms		unsure 🔍
-3% - +1%
-1.49ms - +0.32ms
preact-local44.75ms - 46.16msunsure 🔍
-3% - +1%
-1.34ms - +0.56ms		-faster ✔
0% - 4%
0.02ms - 1.93ms
preact-hooks45.78ms - 47.08msunsure 🔍
-1% - +3%
-0.32ms - +1.49ms		slower ❌
0% - 4%
0.02ms - 1.93ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master67.91ms - 69.84ms-unsure 🔍
-3% - +1%
-2.10ms - +0.71ms		unsure 🔍
-4% - +0%
-2.52ms - +0.31ms
preact-local68.55ms - 70.59msunsure 🔍
-1% - +3%
-0.71ms - +2.10ms		-unsure 🔍
-3% - +1%
-1.87ms - +1.04ms
preact-hooks68.94ms - 71.02msunsure 🔍
-0% - +4%
-0.31ms - +2.52ms		unsure 🔍
-2% - +3%
-1.04ms - +1.87ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master47.92ms - 51.60ms-unsure 🔍
-4% - +6%
-2.16ms - +2.91ms		unsure 🔍
-4% - +7%
-1.80ms - +3.22ms
preact-local47.64ms - 51.13msunsure 🔍
-6% - +4%
-2.91ms - +2.16ms		-unsure 🔍
-4% - +6%
-2.11ms - +2.77ms
preact-hooks47.34ms - 50.76msunsure 🔍
-6% - +4%
-3.22ms - +1.80ms		unsure 🔍
-6% - +4%
-2.77ms - +2.11ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master58.51ms - 62.75ms-unsure 🔍
-5% - +5%
-2.84ms - +3.15ms		faster ✔
1% - 10%
0.71ms - 6.44ms
preact-local58.36ms - 62.59msunsure 🔍
-5% - +5%
-3.15ms - +2.84ms		-faster ✔
1% - 10%
0.87ms - 6.59ms
preact-hooks62.28ms - 66.13msslower ❌
1% - 11%
0.71ms - 6.44ms		slower ❌
1% - 11%
0.87ms - 6.59ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master60.94ms - 63.26ms-unsure 🔍
-1% - +4%
-0.72ms - +2.27ms		unsure 🔍
-4% - +1%
-2.42ms - +0.71ms
preact-local60.39ms - 62.26msunsure 🔍
-4% - +1%
-2.27ms - +0.72ms		-faster ✔
0% - 5%
0.22ms - 3.04ms
preact-hooks61.90ms - 64.01msunsure 🔍
-1% - +4%
-0.71ms - +2.42ms		slower ❌
0% - 5%
0.22ms - 3.04ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master41.11ms - 45.42ms-unsure 🔍
-4% - +10%
-1.63ms - +4.28ms		unsure 🔍
-8% - +6%
-3.50ms - +2.66ms
preact-local39.92ms - 43.97msunsure 🔍
-10% - +4%
-4.28ms - +1.63ms		-unsure 🔍
-11% - +3%
-4.74ms - +1.25ms
preact-hooks41.48ms - 45.89msunsure 🔍
-6% - +8%
-2.66ms - +3.50ms		unsure 🔍
-3% - +11%
-1.25ms - +4.74ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master44.85ms - 47.20ms-unsure 🔍
-4% - +3%
-2.03ms - +1.25ms		unsure 🔍
-3% - +4%
-1.53ms - +1.67ms
preact-local45.28ms - 47.56msunsure 🔍
-3% - +4%
-1.25ms - +2.03ms		-unsure 🔍
-2% - +4%
-1.12ms - +2.03ms
preact-hooks44.87ms - 47.05msunsure 🔍
-4% - +3%
-1.67ms - +1.53ms		unsure 🔍
-4% - +2%
-2.03ms - +1.12ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.44ms - 3.44ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.02ms - 0.03ms
preact-local3.44ms - 3.45msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.03ms
preact-hooks3.46ms - 3.47msslower ❌
0% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.03ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1996.27ms - 2027.68ms-unsure 🔍
-1% - +1%
-19.35ms - +20.85ms		unsure 🔍
-2% - +1%
-33.99ms - +16.41ms
preact-local1998.69ms - 2023.76msunsure 🔍
-1% - +1%
-20.85ms - +19.35ms		-unsure 🔍
-2% - +1%
-32.89ms - +13.81ms
preact-hooks2001.06ms - 2040.47msunsure 🔍
-1% - +2%
-16.41ms - +33.99ms		unsure 🔍
-1% - +2%
-13.81ms - +32.89ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.40ms - 25.44ms-unsure 🔍
-0% - +0%
-0.04ms - +0.02ms		unsure 🔍
-0% - +0%
-0.04ms - +0.02ms
preact-local25.41ms - 25.46msunsure 🔍
-0% - +0%
-0.02ms - +0.04ms		-unsure 🔍
-0% - +0%
-0.03ms - +0.03ms
preact-hooks25.41ms - 25.45msunsure 🔍
-0% - +0%
-0.02ms - +0.04ms		unsure 🔍
-0% - +0%
-0.03ms - +0.03ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master31.62ms - 32.98ms-unsure 🔍
-3% - +3%
-0.93ms - +1.04ms		unsure 🔍
-2% - +3%
-0.70ms - +1.04ms
preact-local31.54ms - 32.95msunsure 🔍
-3% - +3%
-1.04ms - +0.93ms		-unsure 🔍
-2% - +3%
-0.77ms - +1.00ms
preact-hooks31.60ms - 32.66msunsure 🔍
-3% - +2%
-1.04ms - +0.70ms		unsure 🔍
-3% - +2%
-1.00ms - +0.77ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.58ms - 1.58ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.58ms - 1.58msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.60ms - 1.60msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master113.76ms - 116.21ms-unsure 🔍
-3% - +1%
-2.98ms - +1.20ms		unsure 🔍
-1% - +2%
-1.46ms - +1.78ms
preact-local114.19ms - 117.56msunsure 🔍
-1% - +3%
-1.20ms - +2.98ms		-unsure 🔍
-1% - +3%
-0.94ms - +3.05ms
preact-hooks113.77ms - 115.88msunsure 🔍
-2% - +1%
-1.78ms - +1.46ms		unsure 🔍
-3% - +1%
-3.05ms - +0.94ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master13.47ms - 14.26ms-unsure 🔍
-8% - +0%
-1.22ms - +0.06ms		unsure 🔍
-0% - +9%
-0.03ms - +1.14ms
preact-local13.94ms - 14.95msunsure 🔍
-1% - +9%
-0.06ms - +1.22ms		-slower ❌
3% - 14%
0.47ms - 1.80ms
preact-hooks12.88ms - 13.74msunsure 🔍
-8% - +0%
-1.14ms - +0.03ms		faster ✔
3% - 12%
0.47ms - 1.80ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master41.66ms - 44.05ms-unsure 🔍
-2% - +5%
-0.93ms - +2.27ms		unsure 🔍
-7% - +1%
-3.12ms - +0.42ms
preact-local41.12ms - 43.26msunsure 🔍
-5% - +2%
-2.27ms - +0.93ms		-faster ✔
1% - 8%
0.33ms - 3.71ms
preact-hooks42.90ms - 45.52msunsure 🔍
-1% - +7%
-0.42ms - +3.12ms		slower ❌
1% - 9%
0.33ms - 3.71ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.63ms - 4.63ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - +0%
-0.02ms - +0.00ms
preact-local4.63ms - 4.63msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - +0%
-0.02ms - +0.00ms
preact-hooks4.63ms - 4.64msunsure 🔍
-0% - +0%
-0.00ms - +0.02ms		unsure 🔍
-0% - +0%
-0.00ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master2.85ms - 2.92ms-unsure 🔍
-0% - +3%
-0.01ms - +0.10ms		faster ✔
3% - 6%
0.08ms - 0.18ms
preact-local2.80ms - 2.88msunsure 🔍
-3% - +0%
-0.10ms - +0.01ms		-faster ✔
4% - 7%
0.11ms - 0.22ms
preact-hooks2.97ms - 3.05msslower ❌
3% - 6%
0.08ms - 0.18ms		slower ❌
4% - 8%
0.11ms - 0.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.81ms - 0.81ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms		faster ✔
2% - 2%
0.01ms - 0.01ms
preact-local0.81ms - 0.81msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-faster ✔
2% - 2%
0.01ms - 0.01ms
preact-hooks0.83ms - 0.83msslower ❌
2% - 2%
0.01ms - 0.01ms		slower ❌
2% - 2%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master55.68ms - 56.38ms-unsure 🔍
-1% - +1%
-0.38ms - +0.61ms		faster ✔
1% - 2%
0.32ms - 1.32ms
preact-local55.57ms - 56.26msunsure 🔍
-1% - +1%
-0.61ms - +0.38ms		-faster ✔
1% - 3%
0.44ms - 1.43ms
preact-hooks56.50ms - 57.21msslower ❌
1% - 2%
0.32ms - 1.32ms		slower ❌
1% - 3%
0.44ms - 1.43ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.07ms - 1.07ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.02ms
preact-local1.07ms - 1.07msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.02ms
preact-hooks1.09ms - 1.09msslower ❌
2% - 2%
0.02ms - 0.02ms		slower ❌
2% - 2%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Mar 30, 2023 •
edited
Loading

Coverage Status

Coverage: 99.548% (+0.0007%) from 99.548% when pulling 169c852 on improve-perf into 87e5083 on master.

@github-actions
Copy link

github-actions bot commented Mar 30, 2023 •
edited
Loading

Size Change: -9 B (0%)

Total Size: 54.3 kB

Filename Size Change
dist/preact.js 4.21 kB -3 B (0%)
dist/preact.min.js 4.24 kB -1 B
dist/preact.min.umd.js 4.26 kB -1 B
dist/preact.module.js 4.23 kB -3 B (0%)
dist/preact.umd.js 4.27 kB -1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.91 kB 0 B
compat/dist/compat.module.js 3.84 kB 0 B
compat/dist/compat.umd.js 3.98 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.min.module.js 4.24 kB 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.61 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 4f2af1c into master Mar 31, 2023
@JoviDeCroock JoviDeCroock deleted the improve-perf branch March 31, 2023 06:02
@JoviDeCroock JoviDeCroock mentioned this pull request May 13, 2023
Merged
JoviDeCroock added a commit that referenced this pull request Jan 22, 2024
@JoviDeCroock
backport #3956
0726ad3
JoviDeCroock added a commit that referenced this pull request Jan 23, 2024
@JoviDeCroock
Backport 10.14 release line (#4263)
f0144e6 
* backport #3968

* backport #3964

* backport #3997

* backport #3995

* backport #3970

* backport #3971

* backport #3990

* backport #3963

* backport #3962

* backport #3960

* backport #3956

* Revert "backport #3963"

This reverts commit 86a372a.

* define public type

* fix newline issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @marvinhagemeister