Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rowspan and colspan not cleared #3997

Merged
merged 1 commit into from
May 9, 2023
Merged

Fix rowspan and colspan not cleared #3997

merged 1 commit into from
May 9, 2023

Conversation

marvinhagemeister
Copy link
Member

Fixes #3969 .

@github-actions
Copy link

github-actions bot commented May 8, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: slower ❌ 0% - 5% (0.49ms - 6.24ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -2% - +5% (-1.59ms - +3.32ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-5.25ms - +11.04ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +2% (-0.16ms - +0.36ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +2% (-3.60ms - +2.70ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -4% - +3% (-1.20ms - +0.89ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +2% (-0.04ms - +0.06ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +2% (-0.12ms - +1.05ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.02ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +1% (-0.00ms - +0.08ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +1% (-0.00ms - +0.05ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +2% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master133.02ms - 137.00ms-faster ✔
0% - 4%
0.49ms - 6.24ms		unsure 🔍
-4% - +0%
-6.14ms - +0.57ms
preact-local136.30ms - 140.45msslower ❌
0% - 5%
0.49ms - 6.24ms		-unsure 🔍
-2% - +3%
-2.83ms - +3.99ms
preact-hooks135.09ms - 140.50msunsure 🔍
-0% - +5%
-0.57ms - +6.14ms		unsure 🔍
-3% - +2%
-3.99ms - +2.83ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.36ms - 3.38ms-unsure 🔍
-0% - +0%
-0.02ms - +0.01ms		faster ✔
0% - 1%
0.01ms - 0.04ms
preact-local3.37ms - 3.38msunsure 🔍
-0% - +0%
-0.01ms - +0.02ms		-faster ✔
0% - 1%
0.01ms - 0.03ms
preact-hooks3.39ms - 3.41msslower ❌
0% - 1%
0.01ms - 0.04ms		slower ❌
0% - 1%
0.01ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master43.00ms - 44.48ms-unsure 🔍
-2% - +3%
-0.67ms - +1.46ms		unsure 🔍
-3% - +2%
-1.33ms - +0.70ms
preact-local42.58ms - 44.11msunsure 🔍
-3% - +2%
-1.46ms - +0.67ms		-unsure 🔍
-4% - +1%
-1.75ms - +0.32ms
preact-hooks43.36ms - 44.75msunsure 🔍
-2% - +3%
-0.70ms - +1.33ms		unsure 🔍
-1% - +4%
-0.32ms - +1.75ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master65.98ms - 68.20ms-unsure 🔍
-0% - +5%
-0.23ms - +3.34ms		unsure 🔍
-2% - +3%
-1.39ms - +1.76ms
preact-local64.13ms - 66.93msunsure 🔍
-5% - +0%
-3.34ms - +0.23ms		-unsure 🔍
-5% - +1%
-3.16ms - +0.42ms
preact-hooks65.78ms - 68.02msunsure 🔍
-3% - +2%
-1.76ms - +1.39ms		unsure 🔍
-1% - +5%
-0.42ms - +3.16ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master44.86ms - 49.78ms-unsure 🔍
-4% - +10%
-1.94ms - +4.47ms		unsure 🔍
-6% - +7%
-2.94ms - +3.46ms
preact-local44.00ms - 48.11msunsure 🔍
-9% - +4%
-4.47ms - +1.94ms		-unsure 🔍
-8% - +4%
-3.90ms - +1.90ms
preact-hooks45.01ms - 49.10msunsure 🔍
-7% - +6%
-3.46ms - +2.94ms		unsure 🔍
-4% - +9%
-1.90ms - +3.90ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master55.46ms - 59.70ms-unsure 🔍
-5% - +6%
-2.76ms - +3.34ms		unsure 🔍
-9% - +1%
-5.56ms - +0.94ms
preact-local55.10ms - 59.48msunsure 🔍
-6% - +5%
-3.34ms - +2.76ms		-unsure 🔍
-10% - +1%
-5.90ms - +0.70ms
preact-hooks57.43ms - 62.36msunsure 🔍
-2% - +10%
-0.94ms - +5.56ms		unsure 🔍
-1% - +10%
-0.70ms - +5.90ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master57.23ms - 60.06ms-unsure 🔍
-2% - +5%
-0.93ms - +2.62ms		unsure 🔍
-6% - +1%
-3.69ms - +0.51ms
preact-local56.73ms - 58.86msunsure 🔍
-4% - +2%
-2.62ms - +0.93ms		-faster ✔
1% - 7%
0.56ms - 4.32ms
preact-hooks58.69ms - 61.78msunsure 🔍
-1% - +6%
-0.51ms - +3.69ms		slower ❌
1% - 8%
0.56ms - 4.32ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master35.50ms - 38.90ms-unsure 🔍
-12% - +1%
-4.64ms - +0.46ms		unsure 🔍
-14% - +0%
-5.73ms - +0.15ms
preact-local37.39ms - 41.19msunsure 🔍
-1% - +13%
-0.46ms - +4.64ms		-unsure 🔍
-9% - +6%
-3.76ms - +2.37ms
preact-hooks37.59ms - 42.38msunsure 🔍
-1% - +16%
-0.15ms - +5.73ms		unsure 🔍
-6% - +10%
-2.37ms - +3.76ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master69.58ms - 72.61ms-unsure 🔍
-5% - +2%
-3.32ms - +1.59ms		unsure 🔍
-5% - +2%
-3.53ms - +1.21ms
preact-local70.03ms - 73.89msunsure 🔍
-2% - +5%
-1.59ms - +3.32ms		-unsure 🔍
-4% - +3%
-2.95ms - +2.37ms
preact-hooks70.43ms - 74.08msunsure 🔍
-2% - +5%
-1.21ms - +3.53ms		unsure 🔍
-3% - +4%
-2.37ms - +2.95ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.29ms - 3.30ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.29ms - 3.30msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.31ms - 3.32msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1183.73ms - 1193.43ms-unsure 🔍
-1% - +0%
-11.04ms - +5.25ms		unsure 🔍
-1% - +0%
-16.66ms - +0.28ms
preact-local1184.93ms - 1198.02msunsure 🔍
-0% - +1%
-5.25ms - +11.04ms		-unsure 🔍
-1% - +0%
-14.84ms - +4.24ms
preact-hooks1189.83ms - 1203.72msunsure 🔍
-0% - +1%
-0.28ms - +16.66ms		unsure 🔍
-0% - +1%
-4.24ms - +14.84ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.36ms - 25.37ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-local25.36ms - 25.37msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-hooks25.38ms - 25.38msunsure 🔍
+0% - +0%
+0.01ms - +0.02ms		unsure 🔍
+0% - +0%
+0.01ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master22.12ms - 22.48ms-unsure 🔍
-2% - +1%
-0.36ms - +0.16ms		unsure 🔍
-1% - +2%
-0.12ms - +0.40ms
preact-local22.20ms - 22.58msunsure 🔍
-1% - +2%
-0.16ms - +0.36ms		-unsure 🔍
-0% - +2%
-0.03ms - +0.50ms
preact-hooks21.97ms - 22.34msunsure 🔍
-2% - +1%
-0.40ms - +0.12ms		unsure 🔍
-2% - +0%
-0.50ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.44ms - 1.46ms-unsure 🔍
-0% - +1%
-0.00ms - +0.02ms		faster ✔
0% - 2%
0.00ms - 0.02ms
preact-local1.43ms - 1.44msunsure 🔍
-1% - +0%
-0.02ms - +0.00ms		-faster ✔
1% - 2%
0.02ms - 0.03ms
preact-hooks1.46ms - 1.46msslower ❌
0% - 2%
0.00ms - 0.02ms		slower ❌
1% - 2%
0.02ms - 0.03ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master119.73ms - 123.53ms-unsure 🔍
-2% - +3%
-2.70ms - +3.60ms		unsure 🔍
-1% - +4%
-0.88ms - +4.24ms
preact-local118.67ms - 123.70msunsure 🔍
-3% - +2%
-3.60ms - +2.70ms		-unsure 🔍
-2% - +4%
-1.81ms - +4.28ms
preact-hooks118.24ms - 121.66msunsure 🔍
-3% - +1%
-4.24ms - +0.88ms		unsure 🔍
-4% - +1%
-4.28ms - +1.81ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master5.98ms - 6.05ms-unsure 🔍
-1% - +0%
-0.08ms - +0.00ms		faster ✔
0% - 1%
0.00ms - 0.09ms
preact-local6.02ms - 6.08msunsure 🔍
-0% - +1%
-0.00ms - +0.08ms		-unsure 🔍
-1% - +1%
-0.05ms - +0.04ms
preact-hooks6.03ms - 6.09msslower ❌
0% - 2%
0.00ms - 0.09ms		unsure 🔍
-1% - +1%
-0.04ms - +0.05ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master27.72ms - 29.09ms-unsure 🔍
-3% - +4%
-0.89ms - +1.20ms		unsure 🔍
-1% - +6%
-0.36ms - +1.70ms
preact-local27.46ms - 29.04msunsure 🔍
-4% - +3%
-1.20ms - +0.89ms		-unsure 🔍
-2% - +6%
-0.58ms - +1.62ms
preact-hooks26.97ms - 28.50msunsure 🔍
-6% - +1%
-1.70ms - +0.36ms		unsure 🔍
-6% - +2%
-1.62ms - +0.58ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.50ms - 4.53ms-unsure 🔍
-1% - +0%
-0.05ms - +0.00ms		faster ✔
1% - 2%
0.03ms - 0.08ms
preact-local4.51ms - 4.56msunsure 🔍
-0% - +1%
-0.00ms - +0.05ms		-faster ✔
0% - 1%
0.00ms - 0.06ms
preact-hooks4.54ms - 4.59msslower ❌
1% - 2%
0.03ms - 0.08ms		slower ❌
0% - 1%
0.00ms - 0.06ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master2.70ms - 2.77ms-unsure 🔍
-2% - +1%
-0.06ms - +0.04ms		faster ✔
5% - 8%
0.13ms - 0.23ms
preact-local2.71ms - 2.78msunsure 🔍
-1% - +2%
-0.04ms - +0.06ms		-faster ✔
4% - 8%
0.12ms - 0.22ms
preact-hooks2.88ms - 2.95msslower ❌
5% - 8%
0.13ms - 0.23ms		slower ❌
4% - 8%
0.12ms - 0.22ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.71ms - 0.72ms-unsure 🔍
-2% - +1%
-0.01ms - +0.01ms		slower ❌
4% - 6%
0.03ms - 0.04ms
preact-local0.71ms - 0.73msunsure 🔍
-1% - +2%
-0.01ms - +0.01ms		-slower ❌
4% - 6%
0.03ms - 0.04ms
preact-hooks0.68ms - 0.69msfaster ✔
4% - 6%
0.03ms - 0.04ms		faster ✔
4% - 6%
0.03ms - 0.04ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.42ms - 55.25ms-unsure 🔍
-2% - +0%
-1.05ms - +0.12ms		faster ✔
1% - 3%
0.70ms - 1.83ms
preact-local54.89ms - 55.71msunsure 🔍
-0% - +2%
-0.12ms - +1.05ms		-faster ✔
0% - 2%
0.25ms - 1.36ms
preact-hooks55.73ms - 56.48msslower ❌
1% - 3%
0.70ms - 1.83ms		slower ❌
0% - 2%
0.25ms - 1.36ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.92ms - 0.92ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 3%
0.02ms - 0.03ms
preact-local0.92ms - 0.92msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 3%
0.02ms - 0.03ms
preact-hooks0.95ms - 0.95msslower ❌
3% - 3%
0.02ms - 0.03ms		slower ❌
3% - 3%
0.02ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented May 8, 2023 •
edited
Loading

Coverage Status

Coverage: 99.706%. Remained the same when pulling 47fdd38 on fix-rowspan-colspan into b114dcc on master.

@github-actions
Copy link

github-actions bot commented May 8, 2023 •
edited
Loading

Size Change: +66 B (0%)

Total Size: 56.7 kB

Filename Size Change
dist/preact.js 4.26 kB +12 B (0%)
dist/preact.min.js 4.29 kB +10 B (0%)
dist/preact.min.module.js 4.29 kB +10 B (0%)
dist/preact.min.umd.js 4.32 kB +11 B (0%)
dist/preact.module.js 4.29 kB +10 B (0%)
dist/preact.umd.js 4.33 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.07 kB 0 B
compat/dist/compat.module.js 4 kB 0 B
compat/dist/compat.umd.js 4.13 kB 0 B
debug/dist/debug.js 3.53 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.61 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit fadadde into master May 9, 2023
@marvinhagemeister marvinhagemeister deleted the fix-rowspan-colspan branch May 9, 2023 06:24
@JoviDeCroock JoviDeCroock mentioned this pull request May 13, 2023
Merged
JoviDeCroock added a commit that referenced this pull request Jan 22, 2024
@JoviDeCroock
backport #3997
08a977f
JoviDeCroock added a commit that referenced this pull request Jan 23, 2024
@JoviDeCroock
Backport 10.14 release line (#4263)
f0144e6 
* backport #3968

* backport #3964

* backport #3997

* backport #3995

* backport #3970

* backport #3971

* backport #3990

* backport #3963

* backport #3962

* backport #3960

* backport #3956

* Revert "backport #3963"

This reverts commit 86a372a.

* define public type

* fix newline issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@andrewiggins andrewiggins andrewiggins approved these changes

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messed up tables with rowSpan/colSpan
4 participants
@marvinhagemeister @coveralls @andrewiggins @JoviDeCroock