Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some JSX attribute types #3970

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Add some JSX attribute types #3970

merged 3 commits into from
Apr 17, 2023

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Apr 16, 2023 •
edited
Loading

  • inert global attribute
  • hidden global attribute: until-found (new) and hidden (missing) value

rschristian
rschristian reviewed Apr 16, 2023
View reviewed changes
src/jsx.d.ts Outdated Show resolved Hide resolved
rschristian
rschristian approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We appreciate you taking the time to add these.

@rschristian rschristian merged commit 7adb147 into preactjs:master Apr 17, 2023
@JoviDeCroock JoviDeCroock mentioned this pull request May 13, 2023
Merged
JoviDeCroock added a commit that referenced this pull request Jan 22, 2024
@JoviDeCroock
backport #3970
91f119e
JoviDeCroock added a commit that referenced this pull request Jan 23, 2024
@JoviDeCroock
Backport 10.14 release line (#4263)
f0144e6 
* backport #3968

* backport #3964

* backport #3997

* backport #3995

* backport #3970

* backport #3971

* backport #3990

* backport #3963

* backport #3962

* backport #3960

* backport #3956

* Revert "backport #3963"

This reverts commit 86a372a.

* define public type

* fix newline issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidonng @rschristian