Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting in chip-tool when the wrong quotes are used. #24821

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Improve error reporting in chip-tool when the wrong quotes are used. #24821

merged 2 commits into from
Feb 3, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

In interactive mode, arguments are delimited by single quotes. If our argument init fails, and we have arguments that include mismatched double quotes, there's a good chance the wrong quotes were used in the command, and we should log that.

mmb-davidsmith
mmb-davidsmith approved these changes Feb 2, 2023
View reviewed changes
Copy link

@mmb-davidsmith mmb-davidsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Boris. This is helpful for people coming in new.

vivien-apple
vivien-apple approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@vivien-apple vivien-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it may help

@vivien-apple
Copy link
Contributor

A small nit, it would have been probably better to have a dedicated method for this task. Something like DetectMissingDoubleQuotes just in case we end up adding more methods there.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited
Loading

PR #24821: Size comparison from 10a4677 to 089e47a

Increases (10 builds for linux, nrfconnect, psoc6, telink)
platform target config section 10a4677 089e47a change % change
linux chip-tool debug (read only) 11643345 11643713 368 0.0
.rodata 651301 651429 128 0.0
.text 9468740 9468980 240 0.0
chip-tool-ipv6only arm64 (read only) 11040412 11040796 384 0.0
.rodata 577100 577212 112 0.0
.text 8790020 8790292 272 0.0
tv-casting-app debug (read only) 5700961 5701329 368 0.0
.rodata 365428 365556 128 0.0
.text 5049842 5050082 240 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774152 774156 4 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27077982 27077983 1 0.0
light cy8ckit_062s2_43012 .debug_info 22500526 22500527 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22726205 22726206 1 0.0
telink light-switch-app tlsr9518adk80d text 593070 593072 2 0.0
ota-requestor-app tlsr9518adk80d text 604438 604440 2 0.0
thermostat tlsr9518adk80d text 594646 594650 4 0.0
Decreases (5 builds for bl602, nrfconnect, qpg, telink)
platform target config section 10a4677 089e47a change % change
bl602 lighting-app bl602 .text 1022772 1022770 -2 -0.0
bl602+rpc .text 1053452 1053450 -2 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 763900 763896 -4 -0.0
qpg lock-app qpg6105+debug (read/write) 1115852 1115844 -8 -0.0
.text 562948 562940 -8 -0.0
telink contact-sensor-app tlsr9518adk80d text 579028 579024 -4 -0.0
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 10a4677 089e47a change % change
bl602 lighting-app bl602 (read/write) 1345714 1345714 0 0.0
.bss 94826 94826 0 0.0
.data 9736 9736 0 0.0
.text 1022772 1022770 -2 -0.0
bl602+rpc (read/write) 1390906 1390906 0 0.0
.bss 102874 102874 0 0.0
.data 10128 10128 0 0.0
.text 1053452 1053450 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183691 1183691 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550344 1550344 0 0.0
.debug_aranges 134104 134104 0 0.0
.debug_frame 491108 491108 0 0.0
.debug_info 40210594 40210594 0 0.0
.debug_line 5266876 5266876 0 0.0
.debug_loc 3400982 3400982 0 0.0
.debug_ranges 371752 371752 0 0.0
.debug_str 3535301 3535301 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106768 106768 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572034 572034 0 0.0
.symtab 173280 173280 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951806 951806 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276383 1276383 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698758 1698758 0 0.0
.debug_aranges 142328 142328 0 0.0
.debug_frame 518812 518812 0 0.0
.debug_info 44607075 44607075 0 0.0
.debug_line 5665344 5665344 0 0.0
.debug_loc 3597273 3597273 0 0.0
.debug_ranges 395456 395456 0 0.0
.debug_str 3938539 3938539 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121312 121312 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632631 632631 0 0.0
.symtab 191632 191632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028830 1028830 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677127 677127 0 0.0
(read/write) 174088 174088 0 0.0
.bss 80908 80908 0 0.0
.data 3384 3384 0 0.0
.rodata 87527 87527 0 0.0
.text 589284 589284 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641135 641135 0 0.0
(read/write) 157600 157600 0 0.0
.bss 80100 80100 0 0.0
.data 3384 3384 0 0.0
.rodata 77479 77479 0 0.0
.text 563336 563336 0 0.0
lock-ftd LP_CC2652R7 (read only) 674251 674251 0 0.0
(read/write) 174308 174308 0 0.0
.bss 78340 78340 0 0.0
.data 3312 3312 0 0.0
.rodata 76323 76323 0 0.0
.text 597448 597448 0 0.0
lock-mtd LP_CC2652R7 (read only) 660627 660627 0 0.0
(read/write) 183196 183196 0 0.0
.bss 73604 73604 0 0.0
.data 3312 3312 0 0.0
.rodata 102803 102803 0 0.0
.text 557344 557344 0 0.0
pump-app LP_CC2652R7 (read only) 687071 687071 0 0.0
(read/write) 162224 162224 0 0.0
.bss 78308 78308 0 0.0
.data 3276 3276 0 0.0
.rodata 90447 90447 0 0.0
.text 596144 596144 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672495 672495 0 0.0
(read/write) 176912 176912 0 0.0
.bss 78420 78420 0 0.0
.data 3300 3300 0 0.0
.rodata 86527 86527 0 0.0
.text 585488 585488 0 0.0
shell LP_CC2652R7 (read only) 668382 668382 0 0.0
(read/write) 184904 184904 0 0.0
.bss 82980 82980 0 0.0
.data 3380 3380 0 0.0
.rodata 84262 84262 0 0.0
.text 583808 583808 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584042 584042 0 0.0
.app_xip_area 460828 460828 0 0.0
.bss 65664 65664 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587926 587926 0 0.0
.app_xip_area 459416 459416 0 0.0
.bss 70952 70952 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549546 549546 0 0.0
.app_xip_area 431812 431812 0 0.0
.bss 60224 60224 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read/write) 659592 659592 0 0.0
.bss 76592 76592 0 0.0
.data 2112 2112 0 0.0
.text 561776 561776 0 0.0
light k32w0+release (read/write) 671564 671564 0 0.0
.bss 74376 74376 0 0.0
.data 2064 2064 0 0.0
.text 592396 592396 0 0.0
lock k32w0+release (read/write) 631132 631132 0 0.0
.bss 75144 75144 0 0.0
.data 2084 2084 0 0.0
.text 551176 551176 0 0.0
linux all-clusters-app debug (read only) 3156593 3156593 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283851 283851 0 0.0
.text 2687250 2687250 0 0.0
all-clusters-minimal-app debug (read only) 2972561 2972561 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282539 282539 0 0.0
.text 2507858 2507858 0 0.0
bridge-app debug (read only) 2525473 2525473 0 0.0
(read/write) 132352 132352 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68968 68968 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 214048 214048 0 0.0
.text 2138962 2138962 0 0.0
chip-tool debug (read only) 11643345 11643713 368 0.0
(read/write) 655568 655568 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 619512 619512 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 651301 651429 128 0.0
.text 9468740 9468980 240 0.0
chip-tool-ipv6only arm64 (read only) 11040412 11040796 384 0.0
(read/write) 704920 704920 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648336 648336 0 0.0
.dynamic 560 560 0 0.0
.got 14128 14128 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 577100 577212 112 0.0
.text 8790020 8790292 272 0.0
lighting-app debug+rpc (read only) 2693097 2693097 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229984 229984 0 0.0
.text 2285682 2285682 0 0.0
lock-app debug (read only) 2657297 2657297 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246280 246280 0 0.0
.text 2238434 2238434 0 0.0
ota-provider-app debug (read only) 2225945 2225945 0 0.0
(read/write) 106512 106512 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51608 51608 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197576 197576 0 0.0
.text 1887778 1887778 0 0.0
ota-requestor-app debug (read only) 2387441 2387441 0 0.0
(read/write) 114240 114240 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56376 56376 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204528 204528 0 0.0
.text 2033298 2033298 0 0.0
shell debug (read only) 2686041 2686041 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73136 73136 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241938 241938 0 0.0
.text 2283586 2283586 0 0.0
thermostat-no-ble arm64 (read only) 2507500 2507500 0 0.0
(read/write) 144712 144712 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76992 76992 0 0.0
.dynamic 560 560 0 0.0
.got 5400 5400 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2094720 2094720 0 0.0
tv-app debug (read only) 3315609 3315609 0 0.0
(read/write) 259632 259632 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270648 270648 0 0.0
.text 2850162 2850162 0 0.0
tv-casting-app debug (read only) 5700961 5701329 368 0.0
(read/write) 164632 164632 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 102568 102568 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365428 365556 128 0.0
.text 5049842 5050082 240 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463728 2463728 0 0.0
.bss 215924 215924 0 0.0
.data 5880 5880 0 0.0
.text 1426372 1426372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161056 1161056 0 0.0
bss 143563 143563 0 0.0
rodata 133468 133468 0 0.0
text 804160 804160 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366304 1366304 0 0.0
bss 106022 106022 0 0.0
rodata 210896 210896 0 0.0
text 763900 763896 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107220 1107220 0 0.0
bss 142719 142719 0 0.0
rodata 110608 110608 0 0.0
text 774152 774156 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840840 840840 0 0.0
(read/write) 1756100 1756100 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189832 189832 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251867 1251867 0 0.0
.debug_aranges 111368 111368 0 0.0
.debug_frame 373864 373864 0 0.0
.debug_info 27522110 27522110 0 0.0
.debug_line 3780285 3780285 0 0.0
.debug_loc 3675096 3675096 0 0.0
.debug_ranges 362408 362408 0 0.0
.debug_str 3486134 3486134 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577911 577911 0 0.0
.symtab 424736 424736 0 0.0
.text 0 0 0 0.0
1555208 1555208 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841656 841656 0 0.0
(read/write) 1697876 1697876 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189024 189024 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237538 1237538 0 0.0
.debug_aranges 110632 110632 0 0.0
.debug_frame 376308 376308 0 0.0
.debug_info 27077982 27077983 1 0.0
.debug_line 3788631 3788631 0 0.0
.debug_loc 3658826 3658826 0 0.0
.debug_ranges 360376 360376 0 0.0
.debug_str 3471887 3471887 0 0.0
.heap 841656 841656 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539119 539119 0 0.0
.symtab 410016 410016 0 0.0
.text 1497800 1497800 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849976 849976 0 0.0
(read/write) 1611332 1611332 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180904 180904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071872 1071872 0 0.0
.debug_aranges 102840 102840 0 0.0
.debug_frame 346744 346744 0 0.0
.debug_info 22500526 22500527 1 0.0
.debug_line 3340931 3340931 0 0.0
.debug_loc 3336889 3336889 0 0.0
.debug_ranges 319552 319552 0 0.0
.debug_str 3275133 3275133 0 0.0
.heap 849976 849976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474324 474324 0 0.0
.symtab 377792 377792 0 0.0
.text 1419576 1419576 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844992 844992 0 0.0
(read/write) 1645564 1645564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185880 185880 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073576 1073576 0 0.0
.debug_aranges 103280 103280 0 0.0
.debug_frame 348684 348684 0 0.0
.debug_info 22726205 22726206 1 0.0
.debug_line 3342904 3342904 0 0.0
.debug_loc 3359734 3359734 0 0.0
.debug_ranges 321464 321464 0 0.0
.debug_str 3292359 3292359 0 0.0
.heap 844992 844992 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477700 477700 0 0.0
.symtab 379952 379952 0 0.0
.text 1448824 1448824 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147860 1147860 0 0.0
.bss 99908 99908 0 0.0
.data 848 848 0 0.0
.text 594960 594960 0 0.0
lock-app qpg6105+debug (read/write) 1115852 1115844 -8 -0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 562948 562940 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015720 1015720 0 0.0
bss 98012 98012 0 0.0
text 685812 685812 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952268 952268 0 0.0
bss 97060 97060 0 0.0
text 648108 648108 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857616 857616 0 0.0
bss 89184 89184 0 0.0
text 579028 579024 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873316 873316 0 0.0
bss 89272 89272 0 0.0
text 593070 593072 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950632 950632 0 0.0
bss 97420 97420 0 0.0
text 658466 658466 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887476 887476 0 0.0
bss 90220 90220 0 0.0
text 604438 604440 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877524 877524 0 0.0
bss 90660 90660 0 0.0
text 594646 594650 4 0.0

@bzbarsky-apple
Improve error reporting in chip-tool when the wrong quotes are used.
dbd091b 
In interactive mode, arguments are delimited by single quotes.  If our argument
init fails, and we have arguments that include mismatched double quotes, there's
a good chance the wrong quotes were used in the command, and we should log that.
@bzbarsky-apple
Copy link
Contributor Author

A small nit, it would have been probably better to have a dedicated method for this task. Something like DetectMissingDoubleQuotes just in case we end up adding more methods there.

Done.

@bzbarsky-apple bzbarsky-apple force-pushed the chip-tool-handle-wrong-quotes-better branch from 089e47a to 24ae718 Compare February 2, 2023 18:02
@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited
Loading

PR #24821: Size comparison from 653a5c0 to 24ae718

Increases (12 builds for bl602, bl702, cc13x2_26x2, linux, psoc6, telink)
platform target config section 653a5c0 24ae718 change % change
bl602 lighting-app bl602 .text 1022770 1022774 4 0.0
bl602+rpc .text 1053450 1053452 2 0.0
bl702 lighting-app bl702+rpc (read/write) 1276383 1276399 16 0.0
.debug_info 44607134 4460713 1 0.0
.text 1028832 1028834 2 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183196 183204 8 0.0
linux chip-tool debug (read only) 11644017 11644401 384 0.0
.rodata 651365 651493 128 0.0
.text 9469300 9469556 256 0.0
chip-tool-ipv6only arm64 (read only) 11041172 11041604 432 0.0
.rodata 577172 577300 128 0.0
.text 8790660 8790964 304 0.0
tv-casting-app debug (read only) 5701137 5701521 384 0.0
.rodata 365396 365524 128 0.0
.text 5050002 5050258 256 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27522182 27522183 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27078055 27078056 1 0.0
telink all-clusters-app tlsr9518adk80d text 685822 685824 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 648118 648120 2 0.0
light-switch-app tlsr9518adk80d text 593072 593074 2 0.0
Decreases (4 builds for cc13x2_26x2, psoc6, telink)
platform target config section 653a5c0 24ae718 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 660627 660619 -8 -0.0
.text 557344 557336 -8 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22500600 22500598 -2 -0.0
telink contact-sensor-app tlsr9518adk80d text 579028 579026 -2 -0.0
ota-requestor-app tlsr9518adk80d text 604440 604438 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 653a5c0 24ae718 change % change
bl602 lighting-app bl602 (read/write) 1345714 1345714 0 0.0
.bss 94826 94826 0 0.0
.data 9736 9736 0 0.0
.text 1022770 1022774 4 0.0
bl602+rpc (read/write) 1390906 1390906 0 0.0
.bss 102874 102874 0 0.0
.data 10128 10128 0 0.0
.text 1053450 1053452 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183691 1183691 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550344 1550344 0 0.0
.debug_aranges 134104 134104 0 0.0
.debug_frame 491108 491108 0 0.0
.debug_info 40210653 40210653 0 0.0
.debug_line 5266922 5266922 0 0.0
.debug_loc 3401020 3401020 0 0.0
.debug_ranges 371752 371752 0 0.0
.debug_str 3535301 3535301 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106768 106768 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572034 572034 0 0.0
.symtab 173280 173280 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951808 951808 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276383 1276399 16 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698758 1698758 0 0.0
.debug_aranges 142328 142328 0 0.0
.debug_frame 518812 518812 0 0.0
.debug_info 44607134 4460713 1 0.0
.debug_line 5665390 5665390 0 0.0
.debug_loc 3597311 3597311 0 0.0
.debug_ranges 395456 395456 0 0.0
.debug_str 3938539 3938539 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121312 121312 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632631 632631 0 0.0
.symtab 191632 191632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028832 1028834 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677127 677127 0 0.0
(read/write) 174088 174088 0 0.0
.bss 80908 80908 0 0.0
.data 3384 3384 0 0.0
.rodata 87527 87527 0 0.0
.text 589284 589284 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641135 641135 0 0.0
(read/write) 157600 157600 0 0.0
.bss 80100 80100 0 0.0
.data 3384 3384 0 0.0
.rodata 77479 77479 0 0.0
.text 563336 563336 0 0.0
lock-ftd LP_CC2652R7 (read only) 674251 674251 0 0.0
(read/write) 174308 174308 0 0.0
.bss 78340 78340 0 0.0
.data 3312 3312 0 0.0
.rodata 76323 76323 0 0.0
.text 597448 597448 0 0.0
lock-mtd LP_CC2652R7 (read only) 660627 660619 -8 -0.0
(read/write) 183196 183204 8 0.0
.bss 73604 73604 0 0.0
.data 3312 3312 0 0.0
.rodata 102803 102803 0 0.0
.text 557344 557336 -8 -0.0
pump-app LP_CC2652R7 (read only) 687087 687087 0 0.0
(read/write) 162208 162208 0 0.0
.bss 78308 78308 0 0.0
.data 3276 3276 0 0.0
.rodata 90447 90447 0 0.0
.text 596160 596160 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672495 672495 0 0.0
(read/write) 176912 176912 0 0.0
.bss 78420 78420 0 0.0
.data 3300 3300 0 0.0
.rodata 86527 86527 0 0.0
.text 585488 585488 0 0.0
shell LP_CC2652R7 (read only) 668398 668398 0 0.0
(read/write) 184888 184888 0 0.0
.bss 82980 82980 0 0.0
.data 3380 3380 0 0.0
.rodata 84262 84262 0 0.0
.text 583824 583824 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584042 584042 0 0.0
.app_xip_area 460828 460828 0 0.0
.bss 65664 65664 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587926 587926 0 0.0
.app_xip_area 459416 459416 0 0.0
.bss 70952 70952 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549546 549546 0 0.0
.app_xip_area 431812 431812 0 0.0
.bss 60224 60224 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1037792 1037792 0 0.0
.bss 181592 181592 0 0.0
.data 2044 2044 0 0.0
.text 854132 854132 0 0.0
BRD4187C (read/write) 1151088 1151088 0 0.0
.bss 132888 132888 0 0.0
.data 2544 2544 0 0.0
.text 991060 991060 0 0.0
lock-app BRD4161A+wf200 (read/write) 1065568 1065568 0 0.0
.bss 153120 153120 0 0.0
.data 2052 2052 0 0.0
.text 910376 910376 0 0.0
window-app BRD4187C (read/write) 1145972 1145972 0 0.0
.bss 134392 134392 0 0.0
.data 2572 2572 0 0.0
.text 984412 984412 0 0.0
esp32 all-clusters-app c3devkit (read only) 1047052 1047052 0 0.0
(read/write) 1518674 1518674 0 0.0
.dram0.bss 77992 77992 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220664 220664 0 0.0
.flash.text 1047052 1047052 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1098867 1098867 0 0.0
(read/write) 500307 500307 0 0.0
.dram0.bss 83040 83040 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 249424 249424 0 0.0
.flash.text 1093483 1093483 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659592 659592 0 0.0
.bss 76592 76592 0 0.0
.data 2112 2112 0 0.0
.text 561776 561776 0 0.0
light k32w0+release (read/write) 671580 671580 0 0.0
.bss 74376 74376 0 0.0
.data 2064 2064 0 0.0
.text 592412 592412 0 0.0
lock k32w0+release (read/write) 631132 631132 0 0.0
.bss 75144 75144 0 0.0
.data 2084 2084 0 0.0
.text 551176 551176 0 0.0
linux all-clusters-app debug (read only) 3156609 3156609 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283851 283851 0 0.0
.text 2687266 2687266 0 0.0
all-clusters-minimal-app debug (read only) 2972577 2972577 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282539 282539 0 0.0
.text 2507874 2507874 0 0.0
bridge-app debug (read only) 2525489 2525489 0 0.0
(read/write) 132352 132352 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68968 68968 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 214048 214048 0 0.0
.text 2138978 2138978 0 0.0
chip-tool debug (read only) 11644017 11644401 384 0.0
(read/write) 655568 655568 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 619512 619512 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 651365 651493 128 0.0
.text 9469300 9469556 256 0.0
chip-tool-ipv6only arm64 (read only) 11041172 11041604 432 0.0
(read/write) 704936 704936 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648352 648352 0 0.0
.dynamic 560 560 0 0.0
.got 14128 14128 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 577172 577300 128 0.0
.text 8790660 8790964 304 0.0
lighting-app debug+rpc (read only) 2693097 2693097 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229984 229984 0 0.0
.text 2285682 2285682 0 0.0
lock-app debug (read only) 2657297 2657297 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246280 246280 0 0.0
.text 2238434 2238434 0 0.0
ota-provider-app debug (read only) 2225945 2225945 0 0.0
(read/write) 106512 106512 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51608 51608 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197576 197576 0 0.0
.text 1887778 1887778 0 0.0
ota-requestor-app debug (read only) 2387441 2387441 0 0.0
(read/write) 114240 114240 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56376 56376 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204528 204528 0 0.0
.text 2033298 2033298 0 0.0
shell debug (read only) 2686057 2686057 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73136 73136 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241938 241938 0 0.0
.text 2283602 2283602 0 0.0
thermostat-no-ble arm64 (read only) 2507500 2507500 0 0.0
(read/write) 144712 144712 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76992 76992 0 0.0
.dynamic 560 560 0 0.0
.got 5400 5400 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2094720 2094720 0 0.0
tv-app debug (read only) 3315657 3315657 0 0.0
(read/write) 259632 259632 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270648 270648 0 0.0
.text 2850210 2850210 0 0.0
tv-casting-app debug (read only) 5701137 5701521 384 0.0
(read/write) 164664 164664 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 102600 102600 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365396 365524 128 0.0
.text 5050002 5050258 256 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463728 2463728 0 0.0
.bss 215924 215924 0 0.0
.data 5880 5880 0 0.0
.text 1426372 1426372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161056 1161056 0 0.0
bss 143563 143563 0 0.0
rodata 133468 133468 0 0.0
text 804168 804168 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366320 1366320 0 0.0
bss 106022 106022 0 0.0
rodata 210896 210896 0 0.0
text 763908 763908 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107236 1107236 0 0.0
bss 142719 142719 0 0.0
rodata 110608 110608 0 0.0
text 774164 774164 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840840 840840 0 0.0
(read/write) 1756100 1756100 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189832 189832 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251867 1251867 0 0.0
.debug_aranges 111368 111368 0 0.0
.debug_frame 373864 373864 0 0.0
.debug_info 27522182 27522183 1 0.0
.debug_line 3780345 3780345 0 0.0
.debug_loc 3675138 3675138 0 0.0
.debug_ranges 362408 362408 0 0.0
.debug_str 3486134 3486134 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577911 577911 0 0.0
.symtab 424736 424736 0 0.0
.text 1555208 1555208 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841656 841656 0 0.0
(read/write) 1697876 1697876 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189024 189024 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237538 1237538 0 0.0
.debug_aranges 110632 110632 0 0.0
.debug_frame 376308 376308 0 0.0
.debug_info 27078055 27078056 1 0.0
.debug_line 3788691 3788691 0 0.0
.debug_loc 3658868 3658868 0 0.0
.debug_ranges 360376 360376 0 0.0
.debug_str 3471887 3471887 0 0.0
.heap 841656 841656 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539119 539119 0 0.0
.symtab 410016 410016 0 0.0
.text 1497800 1497800 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849976 849976 0 0.0
(read/write) 1611332 1611332 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180904 180904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071872 1071872 0 0.0
.debug_aranges 102840 102840 0 0.0
.debug_frame 346744 346744 0 0.0
.debug_info 22500600 22500598 -2 -0.0
.debug_line 3340991 3340991 0 0.0
.debug_loc 3336931 3336931 0 0.0
.debug_ranges 319552 319552 0 0.0
.debug_str 3275133 3275133 0 0.0
.heap 849976 849976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474324 474324 0 0.0
.symtab 377792 377792 0 0.0
.text 1419576 1419576 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844992 844992 0 0.0
(read/write) 1645564 1645564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185880 185880 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073576 1073576 0 0.0
.debug_aranges 103280 103280 0 0.0
.debug_frame 348684 348684 0 0.0
.debug_info 22726205 22726205 0 0.0
.debug_line 3342904 3342904 0 0.0
.debug_loc 3359734 3359734 0 0.0
.debug_ranges 321464 321464 0 0.0
.debug_str 3292359 3292359 0 0.0
.heap 844992 844992 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477700 477700 0 0.0
.symtab 379952 379952 0 0.0
.text 1448824 1448824 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147876 1147876 0 0.0
.bss 99908 99908 0 0.0
.data 848 848 0 0.0
.text 594976 594976 0 0.0
lock-app qpg6105+debug (read/write) 1115852 1115852 0 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 562948 562948 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015728 1015728 0 0.0
bss 98012 98012 0 0.0
text 685822 685824 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952284 952284 0 0.0
bss 97060 97060 0 0.0
text 648118 648120 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857616 857616 0 0.0
bss 89184 89184 0 0.0
text 579028 579026 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873316 873316 0 0.0
bss 89272 89272 0 0.0
text 593072 593074 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950648 950648 0 0.0
bss 97420 97420 0 0.0
text 658478 658478 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887476 887476 0 0.0
bss 90220 90220 0 0.0
text 604440 604438 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877524 877524 0 0.0
bss 90660 90660 0 0.0
text 594648 594648 0 0.0

@yufengwangca yufengwangca merged commit bdfee0e into project-chip:master Feb 3, 2023
@bzbarsky-apple bzbarsky-apple deleted the chip-tool-handle-wrong-quotes-better branch February 3, 2023 02:33
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Improve error reporting in chip-tool when the wrong quotes are used. (p…
ae45e3f 
…roject-chip#24821)

* Improve error reporting in chip-tool when the wrong quotes are used.

In interactive mode, arguments are delimited by single quotes.  If our argument
init fails, and we have arguments that include mismatched double quotes, there's
a good chance the wrong quotes were used in the command, and we should log that.

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmb-davidsmith mmb-davidsmith mmb-davidsmith approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @vivien-apple @andy31415 @mmb-davidsmith @yufengwangca