-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix generated struct variable type #29360
Merged
mergify
merged 9 commits into
project-chip:master
from
joonhaengHeo:update_kotlin_struct_library
Sep 21, 2023
Merged
[Android] Fix generated struct variable type #29360
mergify
merged 9 commits into
project-chip:master
from
joonhaengHeo:update_kotlin_struct_library
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29360: Size comparison from bfa9b4c to 4fe25cb Increases (1 build for telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…o/connectedhomeip into update_kotlin_struct_library
PR #29360: Size comparison from bfa9b4c to 7063450 Full report (4 builds for cc32xx, mbed, qpg)
|
PR #29360: Size comparison from bfa9b4c to c854cb9 Full report (9 builds for cc32xx, k32w, linux, mbed, qpg)
|
yunhanw-google
approved these changes
Sep 21, 2023
PR #29360: Size comparison from bfa9b4c to fbdeb7c Increases (1 build for telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
saurabhst
approved these changes
Sep 21, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Fix generated struct variable type * generated files.gni * Update Struct Class for avoiding build error * Update unit test * update kotlin codestyle * Add jinja test file * Update script test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using CHIPClusters.jar, a problem occurs when parsing Tlv Data received from Controllee.
The reason is that the scripts does not consider unsigned values.
To fix this, consideration of unsinged values was added, and the files.gni file could be automatically created to maintain the latest library.
In the case of Value's List[Type], we confirmed that it is implemented as
TLV::kTLVType_Array
.