-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-state-metrics] New helm chart #854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prometheus-community/helm-charts
Please review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the other parts of the chart are copied from stable! Thanks!
# Helm 3 | ||
$ helm install [RELEASE_NAME] kube-state-metrics/kube-state-metrics [flags] | ||
|
||
# Helm 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the helm2 instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is in, I'll work on removing it (see: kubernetes/kube-state-metrics#1358 )
Yes, commits come from helm/stable and its current location in kubernetes/kube-state-metrics. Both had DCO (helm) / CLA (kubernetes) requirements. CI is failing due to that (as it only looks for signed-off-by I think), not sure how to resolve that. |
Regarding merging, we could do it manually (after at least one other review!). What was the procedure for the previous chart migrations? |
I think @torstenwalter or @scottrigby had to disable the "only suquash merge" setting temporarly so the single commits could be preserved. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@scottrigby I guess the old commits are missing the sign-off. considering the commit history and nature of it (new chart donation into prom-community), should we have an exception for this? PS: not mentioning the chart-admins. Please feel free to chime in. |
I guess @brancz could help to approve / merge, while keeping git history, too. |
* Added kube-state-metrics * Updated kube-state-metrics version to v0.4.1 * Using different versioning * Moved to stable. Added NOTES.txt. * Fixed readme * Truncating fullname to 63 chars * Adding standard labels * Only add prometheus annotation if value is present * Fixed PR comments * Delete reference to service.name
* upgrade kube-state-metrics version * Bump chart version
…us-community#1710) [stable/kube-state-metrics] Update documented image version
* kube-state-metrics image has been updated * Bump chart version
* name kubeStateMetrics port as 'metrics' * Bump chart version
* [stable/kube-state-metrics] Add RBAC support This commit adds RBAC support for stable/kube-state-metrics. RBAC comes from https://github.com/kubernetes/kube-state-metrics/tree/v1.0.1/kubernetes. * Bump chart version
…ty#1865) * Enable chart upgrades Fixed helm/charts#1726 * Bump chart version
…ed templates with chart name (prometheus-community#2133)
* [stable/kube-state-metrics] Add service type * Incorporate code review feedback * Fix the ordering of type, nodePort and loadBalancerIP
…community#2124) kube-state-metrics has a collector for each kind of Kubernetes resource it collects metrics from. Each of those collectors directly influences the RBAC requirements for the Pods. Additionally due to the nature of how kube-state-metrics is versioned and released it is not easy to determine which collectors are using "alpha" APIs, which are not necessarily enabled in a cluster, but kube-state-metrics by default has all collectors enabled.
…s-community#3163) * Convert registry to k8s.gcr.io * fix hardcoded version in readme
…rometheus-community#3231) * [stable/kube-state-metrics] allow for nodeSelector to be configured * increment version
Co-authored-by: Scott Rigby <scott@r6by.com>
Unblocked by kubernetes/test-infra#20426 Fixes: kubernetes/kube-state-metrics#1342 Reverts kubernetes/kube-state-metrics#1345 Unblocks kubernetes/kube-state-metrics#1325 See kubernetes/kube-state-metrics#1325 (comment) Signed-off-by: Scott Rigby <scott@r6by.com>
in specific namespaces only when user has no access to entire cluster (like in typical OpenShift environments). Signed-off-by: Klavs Klavsen <klavs@enableit.dk>
Signed-off-by: costimuraru <costimuraru@gmail.com>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
It is the same as in the main repository Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Added another commit to remove the license and rebased on main branch. |
/lgtm |
Thanks yes, I'm sorry it took me a while to reply. I have been heads down. The DCO issue was discussed at length here, and finally approved kubernetes/kube-state-metrics#1237. It's the same situation here, therefore I have manually set DCO bot to pass on this PR, and am approving it 👍 |
Thank you @mrueg 🏆 |
For this PR I am enabling "Allow merge commits" option, so that all the previous git history will be retained in |
Disabled "Allow merge commits" option until needed again. |
What this PR does / why we need it:
This migrates the kube-state-metrics helm chart to this repository as mentioned in #839 It includes the history of commits from helm/charts and kubernetes/kube-state-metrics.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Please have a look @scottrigby @tariq1890
Checklist
[prometheus-couchdb-exporter]
)