[kube-state-metrics] New helm chart #854

mrueg · 2021-04-15T22:41:45Z

What this PR does / why we need it:

This migrates the kube-state-metrics helm chart to this repository as mentioned in #839 It includes the history of commits from helm/charts and kubernetes/kube-state-metrics.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes [kube-state-metrics] Migration to this repository #839

Special notes for your reviewer:

Please have a look @scottrigby @tariq1890

Checklist

DCO signed
Chart Version bumped
Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

monotek

@prometheus-community/helm-charts

Please review :)

desaintmartin

I suppose the other parts of the chart are copied from stable! Thanks!

charts/kube-state-metrics/LICENSE

charts/kube-state-metrics/OWNERS

desaintmartin · 2021-04-18T06:52:16Z

charts/kube-state-metrics/README.md

+# Helm 3
+$ helm install [RELEASE_NAME] kube-state-metrics/kube-state-metrics [flags]
+
+# Helm 2


Maybe remove the helm2 instructions?

Once this is in, I'll work on removing it (see: kubernetes/kube-state-metrics#1358 )

mrueg · 2021-04-18T14:48:30Z

I suppose the other parts of the chart are copied from stable! Thanks!

Yes, commits come from helm/stable and its current location in kubernetes/kube-state-metrics. Both had DCO (helm) / CLA (kubernetes) requirements. CI is failing due to that (as it only looks for signed-off-by I think), not sure how to resolve that.

desaintmartin · 2021-04-20T14:45:59Z

Regarding merging, we could do it manually (after at least one other review!). What was the procedure for the previous chart migrations?

monotek · 2021-04-20T17:11:26Z

Regarding merging, we could do it manually (after at least one other review!). What was the procedure for the previous chart migrations?

I think @torstenwalter or @scottrigby had to disable the "only suquash merge" setting temporarly so the single commits could be preserved.

hectorj2f · 2021-04-20T17:34:48Z

/lgtm

gkarthiks

/lgtm

gkarthiks · 2021-04-21T00:18:34Z

@scottrigby I guess the old commits are missing the sign-off. considering the commit history and nature of it (new chart donation into prom-community), should we have an exception for this?

PS: not mentioning the chart-admins. Please feel free to chime in.

monotek · 2021-04-25T11:48:36Z

I guess @brancz could help to approve / merge, while keeping git history, too.

* Added kube-state-metrics * Updated kube-state-metrics version to v0.4.1 * Using different versioning * Moved to stable. Added NOTES.txt. * Fixed readme * Truncating fullname to 63 chars * Adding standard labels * Only add prometheus annotation if value is present * Fixed PR comments * Delete reference to service.name

* upgrade kube-state-metrics version * Bump chart version

…us-community#1710) [stable/kube-state-metrics] Update documented image version

* kube-state-metrics image has been updated * Bump chart version

* name kubeStateMetrics port as 'metrics' * Bump chart version

* [stable/kube-state-metrics] Add RBAC support This commit adds RBAC support for stable/kube-state-metrics. RBAC comes from https://github.com/kubernetes/kube-state-metrics/tree/v1.0.1/kubernetes. * Bump chart version

…ty#1865) * Enable chart upgrades Fixed helm/charts#1726 * Bump chart version

…ed templates with chart name (prometheus-community#2133)

* [stable/kube-state-metrics] Add service type * Incorporate code review feedback * Fix the ordering of type, nodePort and loadBalancerIP

…community#2124) kube-state-metrics has a collector for each kind of Kubernetes resource it collects metrics from. Each of those collectors directly influences the RBAC requirements for the Pods. Additionally due to the nature of how kube-state-metrics is versioned and released it is not easy to determine which collectors are using "alpha" APIs, which are not necessarily enabled in a cluster, but kube-state-metrics by default has all collectors enabled.

…#2718)

…us-community#2849)

…s-community#3163) * Convert registry to k8s.gcr.io * fix hardcoded version in readme

…rometheus-community#3231) * [stable/kube-state-metrics] allow for nodeSelector to be configured * increment version

See also: kubernetes/kube-state-metrics#1342

Co-authored-by: Scott Rigby <scott@r6by.com>

Unblocked by kubernetes/test-infra#20426 Fixes: kubernetes/kube-state-metrics#1342 Reverts kubernetes/kube-state-metrics#1345 Unblocks kubernetes/kube-state-metrics#1325 See kubernetes/kube-state-metrics#1325 (comment) Signed-off-by: Scott Rigby <scott@r6by.com>

in specific namespaces only when user has no access to entire cluster (like in typical OpenShift environments). Signed-off-by: Klavs Klavsen <klavs@enableit.dk>

Signed-off-by: costimuraru <costimuraru@gmail.com>

Signed-off-by: Manuel Rüger <manuel@rueg.eu>

It is the same as in the main repository Signed-off-by: Manuel Rüger <manuel@rueg.eu>

mrueg · 2021-04-25T16:23:41Z

Added another commit to remove the license and rebased on main branch.

hectorj2f · 2021-04-25T18:14:33Z

/lgtm

scottrigby · 2021-04-26T00:41:01Z

@scottrigby I guess the old commits are missing the sign-off. considering the commit history and nature of it (new chart donation into prom-community), should we have an exception for this?

PS: not mentioning the chart-admins. Please feel free to chime in.

Thanks yes, I'm sorry it took me a while to reply. I have been heads down.

The DCO issue was discussed at length here, and finally approved kubernetes/kube-state-metrics#1237. It's the same situation here, therefore I have manually set DCO bot to pass on this PR, and am approving it 👍

scottrigby · 2021-04-26T00:41:49Z

Thank you @mrueg 🏆

scottrigby · 2021-04-26T00:43:08Z

For this PR I am enabling "Allow merge commits" option, so that all the previous git history will be retained in main.

scottrigby · 2021-04-26T00:45:04Z

Disabled "Allow merge commits" option until needed again.

mrueg requested a review from a team as a code owner April 15, 2021 22:41

mrueg mentioned this pull request Apr 15, 2021

charts: Mark chart as deprecated kubernetes/kube-state-metrics#1448

Merged

monotek reviewed Apr 17, 2021

View reviewed changes

monotek requested review from scottrigby and torstenwalter April 17, 2021 21:44

desaintmartin reviewed Apr 18, 2021

View reviewed changes

monotek previously approved these changes Apr 20, 2021

View reviewed changes

mrueg changed the title ~~[WIP] [kube-state-metrics] New helm chart~~ [kube-state-metrics] New helm chart Apr 20, 2021

gkarthiks previously approved these changes Apr 21, 2021

View reviewed changes

fiunchinho and others added 15 commits April 25, 2021 18:21

Upgrade kube-state-metrics version (prometheus-community#1700)

ec2d2a2

* upgrade kube-state-metrics version * Bump chart version

[stable/kube-state-metrics] Update documented image version (promethe…

6a432fb

…us-community#1710) [stable/kube-state-metrics] Update documented image version

kube-state-metrics image has been updated (prometheus-community#1877)

feb667d

* kube-state-metrics image has been updated * Bump chart version

name kubeStateMetrics port as 'metrics' (prometheus-community#1885)

b87f8e6

* name kubeStateMetrics port as 'metrics' * Bump chart version

[stable/kube-state-metrics] Enable chart upgrades (prometheus-communi…

e45cec7

…ty#1865) * Enable chart upgrades Fixed helm/charts#1726 * Bump chart version

[stable/kube-state-metrics] prometheus-community#1785 namespace defin…

25cf83b

…ed templates with chart name (prometheus-community#2133)

[stable/kube-state-metrics] Add service type (prometheus-community#2002)

2e3dc2e

* [stable/kube-state-metrics] Add service type * Incorporate code review feedback * Fix the ordering of type, nodePort and loadBalancerIP

[stable/kube-state-metrics] add readiness probe (prometheus-community…

9d0aacf

…#2718)

[stable/kube-state-metrics] Update to v1.1.0 (prometheus-community#2822)

4cbdb4c

[stable/kube-state-metrics] Add support for pod annotations (promethe…

f2e4574

…us-community#2849)

[stable/kube-state-metrics] Convert registry to k8s.gcr.io (prometheu…

783f69e

…s-community#3163) * Convert registry to k8s.gcr.io * fix hardcoded version in readme

[stable/kube-state-metrics] allow for nodeSelector to be configured (p…

4805df9

…rometheus-community#3231) * [stable/kube-state-metrics] allow for nodeSelector to be configured * increment version

mrueg and others added 18 commits April 25, 2021 18:21

charts: point out that the repo isn't set up yet

e0e34aa

See also: kubernetes/kube-state-metrics#1342

Update charts/kube-state-metrics/README.md

b32f9b6

Co-authored-by: Scott Rigby <scott@r6by.com>

bumped chart version

2b23b02

Fix spacing issue

fd5c750

Bump chart version

cb62fbd

Add useExistingRole and useClusterrole options - allowing installation

ab3b9da

in specific namespaces only when user has no access to entire cluster (like in typical OpenShift environments). Signed-off-by: Klavs Klavsen <klavs@enableit.dk>

Hardcoded telemetry internal port and bumped version

f534903

Fix create role

803672b

added: support for providing extraArgs to ksm

f52f2cb

allow for namespace flag to be passed as a list

f43e17a

Signed-off-by: costimuraru <costimuraru@gmail.com>

chart: Add custom labels to pdb and servicemonitor

166329e

Signed-off-by: Manuel Rüger <manuel@rueg.eu>

chart: Add AppVersion to labels

7caa396

Signed-off-by: Manuel Rüger <manuel@rueg.eu>

chart: Upgrade to multi-arch v1.9.8 image

4342975

update RBAC manifests to v1

7f47bf1

Fix role.yaml for helm2 compatibility

df6eb22

[kube-state-metrics] Fix CI issues

c8f5a4c

Signed-off-by: Manuel Rüger <manuel@rueg.eu>

[kube-state-metrics] Remove license

c06c4e1

It is the same as in the main repository Signed-off-by: Manuel Rüger <manuel@rueg.eu>

mrueg dismissed stale reviews from gkarthiks and monotek via c06c4e1 April 25, 2021 16:22

mrueg force-pushed the migrate-ksm branch from 289681f to c06c4e1 Compare April 25, 2021 16:22

monotek approved these changes Apr 25, 2021

View reviewed changes

scottrigby approved these changes Apr 26, 2021

View reviewed changes

scottrigby merged commit 1f980d9 into prometheus-community:main Apr 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kube-state-metrics] New helm chart #854

[kube-state-metrics] New helm chart #854

mrueg commented Apr 15, 2021 •

edited by scottrigby

Loading

monotek left a comment

desaintmartin left a comment

desaintmartin Apr 18, 2021

mrueg Apr 18, 2021 •

edited

Loading

mrueg commented Apr 18, 2021

desaintmartin commented Apr 20, 2021

monotek commented Apr 20, 2021

hectorj2f commented Apr 20, 2021

gkarthiks left a comment

gkarthiks commented Apr 21, 2021

monotek commented Apr 25, 2021

mrueg commented Apr 25, 2021

hectorj2f commented Apr 25, 2021

scottrigby commented Apr 26, 2021

scottrigby commented Apr 26, 2021

scottrigby commented Apr 26, 2021

scottrigby commented Apr 26, 2021

[kube-state-metrics] New helm chart #854

[kube-state-metrics] New helm chart #854

Conversation

mrueg commented Apr 15, 2021 • edited by scottrigby Loading

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

monotek left a comment

Choose a reason for hiding this comment

desaintmartin left a comment

Choose a reason for hiding this comment

desaintmartin Apr 18, 2021

Choose a reason for hiding this comment

mrueg Apr 18, 2021 • edited Loading

Choose a reason for hiding this comment

mrueg commented Apr 18, 2021

desaintmartin commented Apr 20, 2021

monotek commented Apr 20, 2021

hectorj2f commented Apr 20, 2021

gkarthiks left a comment

Choose a reason for hiding this comment

gkarthiks commented Apr 21, 2021

monotek commented Apr 25, 2021

mrueg commented Apr 25, 2021

hectorj2f commented Apr 25, 2021

scottrigby commented Apr 26, 2021

scottrigby commented Apr 26, 2021

scottrigby commented Apr 26, 2021

scottrigby commented Apr 26, 2021

mrueg commented Apr 15, 2021 •

edited by scottrigby

Loading

mrueg Apr 18, 2021 •

edited

Loading