ENH: Add capability to replace image #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of colors were not taken into account to process PNG Images also properly process mask to transparency closes py-pdf#1787
checks the rendering
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
+ Coverage 93.73% 93.75% +0.02%
==========================================
Files 34 34
Lines 6795 6817 +22
Branches 1338 1341 +3
==========================================
+ Hits 6369 6391 +22
Misses 279 279
Partials 147 147
☔ View full report in Codecov by Sentry. |
|
@MartinThoma |
MartinThoma
reviewed
Jun 13, 2023
MartinThoma
reviewed
Jun 13, 2023
MartinThoma
reviewed
Jun 13, 2023
MartinThoma
changed the title
|
Awesome work @pubpub-zz 🥳 👏 Thank you 🙏 |
|
Thank you so much @pubpub-zz !! |
MartinThoma
added a commit
that referenced
this pull request
Jun 18, 2023
New Features (ENH): - Extraction of inline images (#1850) - Add capability to replace image (#1849) - Extend images interface by returning an ImageFile(File) class (#1848) - Add set_data to EncodedStreamObject (#1854) Bug Fixes (BUG): - Fix RGB FlateEncode Images(PNG) and transparency (#1834) - Generate static appearance for fields (#1864) [Full Changelog](3.9.1...3.10.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add capability to replace images.
This allow capabililty to compress files reducing image quality
closes #1546
For the Reviewer