Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add set_data to EncodedStreamObject #1854

Merged
merged 4 commits into from
Jun 11, 2023

Conversation

pubpub-zz
Copy link
Collaborator

add set_data() for encoded streams
also, complete FlateEncode to get all requierd attributes Ease data manipulation without going through ContentStream (slow) closes #656

add set_data() for encoded streams
also, complete  FlateEncode to get all requierd attributes
Ease data manipulation without going through ContentStream (slow)
closes py-pdf#656
@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
the codecov did not worked. Can you rerun the action ?

pubpub-zz added a commit to pubpub-zz/pypdf that referenced this pull request May 29, 2023
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.09 🎉

Comparison is base (54e027a) 93.53% compared to head (de8e22f) 93.63%.

❗ Current head de8e22f differs from pull request most recent head 6636263. Consider uploading reports for the commit 6636263 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
+ Coverage   93.53%   93.63%   +0.09%     
==========================================
  Files          34       34              
  Lines        6625     6631       +6     
  Branches     1296     1297       +1     
==========================================
+ Hits         6197     6209      +12     
+ Misses        281      276       -5     
+ Partials      147      146       -1     
Impacted Files Coverage Δ
pypdf/generic/_data_structures.py 91.01% <83.33%> (+0.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Jun 11, 2023
@MartinThoma
Copy link
Member

Sorry for the delay 🙈

It looks good to me, but doesn't have full coverage. Should I merge it?

@pubpub-zz
Copy link
Collaborator Author

you can for me

@MartinThoma MartinThoma changed the title ENH : add set_data to EncodedStreamObject ENH: Add set_data to EncodedStreamObject Jun 11, 2023
tests/test_generic.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma merged commit 56b33cc into py-pdf:main Jun 11, 2023
@MartinThoma
Copy link
Member

Very nice work! Thank you 🤗 A lot of people were/are looking forward to this :-)

MartinThoma added a commit that referenced this pull request Jun 18, 2023
New Features (ENH):
-  Extraction of inline images (#1850)
-  Add capability to replace image (#1849)
-  Extend images interface by returning an ImageFile(File) class (#1848)
-  Add set_data to EncodedStreamObject (#1854)

Bug Fixes (BUG):
-  Fix RGB FlateEncode Images(PNG) and transparency (#1834)
-  Generate static appearance for fields (#1864)

[Full Changelog](3.9.1...3.10.0)
@MartinThoma MartinThoma removed the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Aug 14, 2023
@pubpub-zz pubpub-zz deleted the encodedstream branch September 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPDF2.utils.PdfReadError: Creating EncodedStreamObject is not currently supported
2 participants