-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Extraction of inline images #1850
Conversation
Number of colors were not taken into account to process PNG Images also properly process mask to transparency closes py-pdf#1787
checks the rendering
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1850 +/- ##
==========================================
+ Coverage 93.73% 93.87% +0.14%
==========================================
Files 34 34
Lines 6795 6854 +59
Branches 1338 1352 +14
==========================================
+ Hits 6369 6434 +65
+ Misses 279 273 -6
Partials 147 147
☔ View full report in Codecov by Sentry. |
@MartinThoma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @pubpub-zz 😍
Could you please rename FileImage
to ImageFile
?
Co-authored-by: Martin Thoma <info@martin-thoma.de>
as per comment
@ Martin, substitution performed |
@MartinThoma |
Finally the last one is merged @pubpub-zz 🎉 I'm looking foward to release-sunday again 😄 |
I don't want to bother you but #1834 will still have to be merged. 🙄😳 |
New Features (ENH): - Extraction of inline images (#1850) - Add capability to replace image (#1849) - Extend images interface by returning an ImageFile(File) class (#1848) - Add set_data to EncodedStreamObject (#1854) Bug Fixes (BUG): - Fix RGB FlateEncode Images(PNG) and transparency (#1834) - Generate static appearance for fields (#1864) [Full Changelog](3.9.1...3.10.0)
Closes #1368