Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Extraction of inline images #1850

Merged
merged 47 commits into from
Jun 13, 2023
Merged

Conversation

pubpub-zz
Copy link
Collaborator

@pubpub-zz pubpub-zz commented May 20, 2023

Closes #1368

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage: 96.82% and project coverage change: +0.14 🎉

Comparison is base (2213b64) 93.73% compared to head (6da1783) 93.87%.

❗ Current head 6da1783 differs from pull request most recent head 633c43e. Consider uploading reports for the commit 633c43e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   93.73%   93.87%   +0.14%     
==========================================
  Files          34       34              
  Lines        6795     6854      +59     
  Branches     1338     1352      +14     
==========================================
+ Hits         6369     6434      +65     
+ Misses        279      273       -6     
  Partials      147      147              
Impacted Files Coverage Δ
pypdf/_page.py 92.61% <95.00%> (+1.16%) ⬆️
pypdf/_utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

pubpub-zz commented May 23, 2023

@MartinThoma
All yours Third one to be merged

tests/test_page.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinThoma MartinThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @pubpub-zz 😍

Could you please rename FileImage to ImageFile?

@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Jun 11, 2023
pypdf/_page.py Outdated Show resolved Hide resolved
pubpub-zz and others added 3 commits June 11, 2023 19:47
Co-authored-by: Martin Thoma <info@martin-thoma.de>
@pubpub-zz
Copy link
Collaborator Author

@ Martin, substitution performed
Should be good now.

@pubpub-zz
Copy link
Collaborator Author

pubpub-zz commented Jun 11, 2023

@MartinThoma
for readability
You should merge this PR after #1848 and #1849 inthis order.
after this one you can merge #1834

@MartinThoma MartinThoma changed the title ENH : Inline images Extraction ENH: Extraction of inline images Jun 13, 2023
@MartinThoma MartinThoma merged commit 2eee5ed into py-pdf:main Jun 13, 2023
@MartinThoma
Copy link
Member

Finally the last one is merged @pubpub-zz 🎉

I'm looking foward to release-sunday again 😄

@pubpub-zz
Copy link
Collaborator Author

I don't want to bother you but #1834 will still have to be merged. 🙄😳
However I have to fix conflicts... hope to be able to do thant tomorrow evening...

MartinThoma added a commit that referenced this pull request Jun 18, 2023
New Features (ENH):
-  Extraction of inline images (#1850)
-  Add capability to replace image (#1849)
-  Extend images interface by returning an ImageFile(File) class (#1848)
-  Add set_data to EncodedStreamObject (#1854)

Bug Fixes (BUG):
-  Fix RGB FlateEncode Images(PNG) and transparency (#1834)
-  Generate static appearance for fields (#1864)

[Full Changelog](3.9.1...3.10.0)
@pubpub-zz pubpub-zz deleted the inline_images branch September 2, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soon PRs that are almost ready to be merged, issues that get solved pretty soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images not extracted
2 participants