-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non alternate name for Kyiv #108533
Use non alternate name for Kyiv #108533
Conversation
tzdata provides Kiev as an alternative to Kyiv: https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314 But Debian moved it to the tzdata-legacy package breaking the test: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530 This patch switches to the name provided by tzdata.
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
This change looks reasonable, the timezone was renamed in IANA's Time Zone Database release 2022b:
https://data.iana.org/time-zones/tzdb/NEWS The original test was added long before this in 2012: With the intent to not test alternative names but different UTC offsets at different points in history:
|
Thanks @jspricke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
This comment was marked as outdated.
This comment was marked as outdated.
tzdata provides Kiev as an alternative to Kyiv: https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314 But Debian moved it to the tzdata-legacy package breaking the test: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530 This patch switches to the name provided by tzdata. (cherry picked from commit 7659128) Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
GH-108640 is a backport of this pull request to the 3.12 branch. |
GH-108641 is a backport of this pull request to the 3.11 branch. |
tzdata provides Kiev as an alternative to Kyiv: https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314 But Debian moved it to the tzdata-legacy package breaking the test: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530 This patch switches to the name provided by tzdata. (cherry picked from commit 7659128) Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
@jspricke Thanks for the PR! It looks like the CLA bot is a bit confused, see #108533 (comment) and #108640 (comment). I think this might be because you used different email addresses for the commit and for your profile? The easiest thing is probably if you could also sign the CLA with |
@hugovk done. I usually use git@ for my commits, not sure where the github@ is coming from. |
|
|
|
tzdata provides Kiev as an alternative to Kyiv: https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314 But Debian moved it to the tzdata-legacy package breaking the test: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530 This patch switches to the name provided by tzdata. (cherry picked from commit 7659128) Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
|
|
|
|
|
This reverts commit 7659128.
|
…honGH-108641)" This reverts commit 34f84f2.
Something goes wrong, so I'm reverting the change. Different failures on different platforms.
Debian:
It is no longer a trivial change. Please open an issue for further investigation. |
* main: pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568) pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686) pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584) Document Python build requirements (python#108646) pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678) Fix typo in multiprocessing docs (python#108666) pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670) pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657) Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667) pythongh-106320: Remove private _Py_ForgetReference() (python#108664) Mention Ellipsis pickling in the docs (python#103660) Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649) pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632) pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637) pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
- Add loongarch support. Addresses: #1049963. - Address CVE-2023-41105, CVE-2023-40217. * libpython3.12-stdlib: Depend on tzdata. Closes: #1050529. * Add proposed patch to avoid tzdata-legacy, and drop again the dependency on it. See python/cpython#108533.
dependency on it. See python/cpython#108533.
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314
But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530
This patch switches to the name provided by tzdata.