Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non alternate name for Kyiv #108533

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

jspricke
Copy link
Contributor

tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.
@jspricke jspricke requested a review from a team as a code owner August 27, 2023 06:24
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Aug 27, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Aug 27, 2023
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@hugovk
Copy link
Member

hugovk commented Aug 28, 2023

This change looks reasonable, the timezone was renamed in IANA's Time Zone Database release 2022b:

Changes to zone name

Rename Europe/Kiev to Europe/Kyiv, as "Kyiv" is more common in
English now. Spelling of other names in Ukraine has not yet
demonstrably changed in common English practice so for now these
names retain old spellings, as in other countries (e.g.,
Europe/Prague not "Praha", and Europe/Sofia not "Sofiya").

https://data.iana.org/time-zones/tzdb/NEWS

The original test was added long before this in 2012:

With the intent to not test alternative names but different UTC offsets at different points in history:

in many places UTC offset was different at different historical times but standard C library and Python's time module provides a single constant for it. There are plenty of examples that can be found in Olson's database (Europe/Kiev comes to mind) [...]

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Aug 29, 2023
@serhiy-storchaka serhiy-storchaka merged commit 7659128 into python:main Aug 29, 2023
@miss-islington
Copy link
Contributor

Thanks @jspricke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2023
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.
(cherry picked from commit 7659128)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
@bedevere-bot
Copy link

GH-108640 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Aug 29, 2023
@bedevere-bot
Copy link

GH-108641 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 29, 2023
@jspricke jspricke deleted the kiev_kyiv branch August 29, 2023 15:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2023
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.
(cherry picked from commit 7659128)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
@hugovk
Copy link
Member

hugovk commented Aug 29, 2023

@jspricke Thanks for the PR!

It looks like the CLA bot is a bit confused, see #108533 (comment) and #108640 (comment).

I think this might be because you used different email addresses for the commit and for your profile? github@ and git@

The easiest thing is probably if you could also sign the CLA with github@, if that's OK? --> #108640 (comment)

@jspricke
Copy link
Contributor Author

@hugovk done. I usually use git@ for my commits, not sure where the github@ is coming from.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 7659128.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5430) and take a look at the build logs.
  4. Check if the failure is related to this commit (7659128) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5430

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

438 tests OK.

10 slowest tests:

  • test_signal: 4 min 8 sec
  • test.test_concurrent_futures.test_wait: 1 min 11 sec
  • test_logging: 1 min 10 sec
  • test.test_multiprocessing_spawn.test_processes: 54.9 sec
  • test.test_multiprocessing_forkserver.test_processes: 48.8 sec
  • test_ssl: 47.2 sec
  • test_math: 43.5 sec
  • test_io: 37.1 sec
  • test_subprocess: 30.3 sec
  • test_socket: 30.1 sec

1 test failed:
test_email

21 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils
test.test_multiprocessing_fork.test_manager
test.test_multiprocessing_fork.test_misc
test.test_multiprocessing_fork.test_processes
test.test_multiprocessing_fork.test_threads test_devpoll
test_epoll test_gdb test_ioctl test_launcher test_perf_profiler
test_perfmaps test_startfile test_tkinter test_ttk
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_email

Total duration: 8 min 47 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 863, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'UTC' != 'MSK'
- UTC
+ MSK

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian PGO 3.x has failed when building commit 7659128.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/249/builds/6135) and take a look at the build logs.
  4. Check if the failure is related to this commit (7659128) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/249/builds/6135

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

447 tests OK.

10 slowest tests:

  • test_signal: 1 min 12 sec
  • test.test_concurrent_futures.test_wait: 1 min 9 sec
  • test.test_multiprocessing_spawn.test_processes: 41.2 sec
  • test.test_multiprocessing_forkserver.test_processes: 39.9 sec
  • test_io: 32.6 sec
  • test_imaplib: 30.3 sec
  • test_socket: 29.9 sec
  • test_math: 28.6 sec
  • test_xmlrpc: 27.4 sec
  • test_subprocess: 25.8 sec

1 test failed:
test_email

15 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_ioctl test_kqueue test_launcher test_startfile test_tkinter
test_ttk test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_email

Total duration: 10 min 9 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.x.gps-debian-profile-opt.pgo/build/Lib/test/support/__init__.py", line 863, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.x.gps-debian-profile-opt.pgo/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Debian Clang LTO + PGO 3.x has failed when building commit 7659128.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1084/builds/1794) and take a look at the build logs.
  4. Check if the failure is related to this commit (7659128) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1084/builds/1794

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

447 tests OK.

10 slowest tests:

  • test.test_concurrent_futures.test_wait: 1 min 9 sec
  • test_signal: 1 min 7 sec
  • test.test_multiprocessing_spawn.test_processes: 43.9 sec
  • test.test_multiprocessing_forkserver.test_processes: 39.3 sec
  • test_socket: 36.7 sec
  • test_math: 32.3 sec
  • test_imaplib: 32.1 sec
  • test_subprocess: 31.5 sec
  • test_io: 30.8 sec
  • test_xmlrpc: 27.6 sec

1 test failed:
test_email

15 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_ioctl test_kqueue test_launcher test_startfile test_tkinter
test_ttk test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_email

Total duration: 3 min 59 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/support/__init__.py", line 863, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK

serhiy-storchaka pushed a commit that referenced this pull request Aug 29, 2023
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.
(cherry picked from commit 7659128)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.11 has failed when building commit 34f84f2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1030/builds/1313) and take a look at the build logs.
  4. Check if the failure is related to this commit (34f84f2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1030/builds/1313

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

413 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 41 sec
  • test_multiprocessing_spawn: 1 min 55 sec
  • test_multiprocessing_forkserver: 1 min 33 sec
  • test_asyncio: 1 min 3 sec
  • test_logging: 56.7 sec
  • test_signal: 45.0 sec
  • test_ssl: 37.6 sec
  • test_io: 36.8 sec
  • test_capi: 30.8 sec
  • test_subprocess: 29.9 sec

1 test failed:
test_email

17 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_launcher
test_msilib test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_email

Total duration: 6 min 56 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.11.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_37c4ec7f'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.11.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_04e5971b'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.11.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 847, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.11.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'UTC' != 'MSK'
- UTC
+ MSK

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 7659128.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/5667) and take a look at the build logs.
  4. Check if the failure is related to this commit (7659128) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/5667

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

442 tests OK.

10 slowest tests:

  • test_tools: 8 min 46 sec
  • test_math: 3 min 51 sec
  • test_mailbox: 1 min 48 sec
  • test_tokenize: 1 min 43 sec
  • test_unparse: 1 min 39 sec
  • test.test_multiprocessing_spawn.test_processes: 1 min 38 sec
  • test_signal: 1 min 35 sec
  • test.test_multiprocessing_forkserver.test_processes: 1 min 32 sec
  • test_capi: 1 min 31 sec
  • test_cppext: 1 min 28 sec

1 test failed:
test_email

20 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_dbm_ndbm test_devpoll
test_gdb test_idle test_ioctl test_kqueue test_launcher
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_email

Total duration: 36 min 18 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 863, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian PGO 3.11 has failed when building commit 34f84f2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1024/builds/1107) and take a look at the build logs.
  4. Check if the failure is related to this commit (34f84f2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1024/builds/1107

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

419 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 17 sec
  • test_multiprocessing_spawn: 1 min 28 sec
  • test_multiprocessing_forkserver: 1 min 9 sec
  • test_asyncio: 1 min 5 sec
  • test_multiprocessing_fork: 1 min 3 sec
  • test_signal: 46.8 sec
  • test_io: 31.7 sec
  • test_imaplib: 30.3 sec
  • test_xmlrpc: 27.4 sec
  • test_socket: 26.4 sec

1 test failed:
test_email

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_launcher
test_msilib test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_email

Total duration: 9 min 11 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.11.gps-debian-profile-opt.pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_841de619'


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.11.gps-debian-profile-opt.pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_91a5ce23'


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.11.gps-debian-profile-opt.pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_52bcd614'


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.11.gps-debian-profile-opt.pgo/build/Lib/test/support/__init__.py", line 847, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.11.gps-debian-profile-opt.pgo/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Debian Clang LTO + PGO 3.11 has failed when building commit 34f84f2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1085/builds/359) and take a look at the build logs.
  4. Check if the failure is related to this commit (34f84f2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1085/builds/359

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

419 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 22 sec
  • test_multiprocessing_spawn: 1 min 36 sec
  • test_asyncio: 1 min 15 sec
  • test_multiprocessing_forkserver: 1 min 12 sec
  • test_multiprocessing_fork: 1 min 6 sec
  • test_signal: 46.6 sec
  • test_io: 32.7 sec
  • test_imaplib: 30.9 sec
  • test_xmlrpc: 27.6 sec
  • test_socket: 26.7 sec

1 test failed:
test_email

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_launcher
test_msilib test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_email

Total duration: 3 min 21 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.11.gps-arm64-debian.clang.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_e6134afd'


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.11.gps-arm64-debian.clang.lto-pgo/build/Lib/test/support/__init__.py", line 847, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/var/lib/buildbot/workers/arm64-clang/3.11.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.11.gps-arm64-debian.clang.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_25700c27'


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.11.gps-arm64-debian.clang.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_70edd915'

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.11 has failed when building commit 34f84f2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/980/builds/981) and take a look at the build logs.
  4. Check if the failure is related to this commit (34f84f2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/980/builds/981

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

416 tests OK.

10 slowest tests:

  • test_venv: 9 min 41 sec
  • test_largefile: 8 min
  • test_lib2to3: 6 min 18 sec
  • test_multiprocessing_spawn: 3 min 53 sec
  • test_import: 3 min 45 sec
  • test_concurrent_futures: 3 min 24 sec
  • test_multiprocessing_forkserver: 2 min 38 sec
  • test_asyncio: 2 min 35 sec
  • test_importlib: 2 min 20 sec
  • test_regrtest: 2 min 13 sec

1 test failed:
test_email

17 tests skipped:
test_devpoll test_idle test_ioctl test_kqueue test_launcher
test_msilib test_startfile test_tcl test_tix test_tk
test_ttk_guionly test_ttk_textonly test_turtle test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_email

Total duration: 35 min 32 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.11.gps-raspbian.nondebug/build/Lib/test/support/__init__.py", line 847, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/var/lib/buildbot/workers/3.11.gps-raspbian.nondebug/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 29, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.11 has failed when building commit 34f84f2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1007/builds/992) and take a look at the build logs.
  4. Check if the failure is related to this commit (34f84f2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1007/builds/992

Failed tests:

  • test_email

Failed subtests:

  • test_variable_tzname - test.test_email.test_utils.LocaltimeTests.test_variable_tzname

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

414 tests OK.

10 slowest tests:

  • test_tools: 7 min 47 sec
  • test_multiprocessing_spawn: 3 min 30 sec
  • test_concurrent_futures: 3 min 2 sec
  • test_asyncio: 2 min 25 sec
  • test_tokenize: 2 min 16 sec
  • test_multiprocessing_forkserver: 1 min 55 sec
  • test_mailbox: 1 min 50 sec
  • test_unparse: 1 min 42 sec
  • test_unicodedata: 1 min 38 sec
  • test_multiprocessing_fork: 1 min 34 sec

1 test failed:
test_email

19 tests skipped:
test_dbm_ndbm test_devpoll test_gdb test_idle test_ioctl
test_kqueue test_launcher test_msilib test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_email

Total duration: 32 min 37 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.11.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_af8fd709'


Traceback (most recent call last):
  File "/root/buildarea/3.11.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_003b3bfe'


Traceback (most recent call last):
  File "/root/buildarea/3.11.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 847, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.11.angelico-debian-amd64/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK


Traceback (most recent call last):
  File "/root/buildarea/3.11.angelico-debian-amd64/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_7b7dc960'

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 29, 2023
@serhiy-storchaka
Copy link
Member

Something goes wrong, so I'm reverting the change.

Different failures on different platforms.
macOS:

  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'UTC' != 'MSK'
- UTC
+ MSK

Debian:

  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.x.gps-debian-profile-opt.pgo/build/Lib/test/test_email/test_utils.py", line 155, in test_variable_tzname
    self.assertEqual(t1.tzname(), 'MSK')
AssertionError: 'Europe' != 'MSK'
- Europe
+ MSK

It is no longer a trivial change. Please open an issue for further investigation.

serhiy-storchaka added a commit that referenced this pull request Aug 29, 2023
This reverts commit 7659128.

It broke tests on the Debian and macOS buildbots.
serhiy-storchaka added a commit that referenced this pull request Aug 29, 2023
…-108641)" (GH-108650)

This reverts commit 34f84f2.

It broke tests on the Debian and macOS buildbots.
carljm added a commit to carljm/cpython that referenced this pull request Aug 30, 2023
* main:
  pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)
  pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686)
  pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)
  Document Python build requirements (python#108646)
  pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)
  Fix typo in multiprocessing docs (python#108666)
  pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)
  pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)
  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)
  pythongh-106320: Remove private _Py_ForgetReference() (python#108664)
  Mention Ellipsis pickling in the docs (python#103660)
  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)
  pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)
  pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)
  pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
FakeShell pushed a commit to FuriLabs/python3 that referenced this pull request Aug 1, 2024
    - Add loongarch support. Addresses: #1049963.
    - Address CVE-2023-41105, CVE-2023-40217.
  * libpython3.12-stdlib: Depend on tzdata. Closes: #1050529.
  * Add proposed patch to avoid tzdata-legacy, and drop again the
    dependency on it. See  python/cpython#108533.
themylogin pushed a commit to truenas/python that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants