Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Python build requirements #108646

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Document Python build requirements #108646

merged 6 commits into from
Aug 30, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 29, 2023 •
edited by AA-Turner
Loading

@vstinner
Document Python build requirements
76cfe6f 
* Autoconf and aclocal: issue pythonGH-89886
* SQLite 3.15.2: issue pythonGH-105875
* Tcl/Tk 8.5.12: issue pythonGH-91152
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Aug 29, 2023
@vstinner
Copy link
Member Author

  • @erlend-aasland: Please check the Autoconf, aclocal and SQLite minimum versions. -- I copied versions from What's New in Python 3.13
  • @serhiy-storchaka: Please check the Tcl/Tk minimum version.

AA-Turner
AA-Turner reviewed Aug 29, 2023
View reviewed changes
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
@vstinner
Copy link
Member Author

@erlend-aasland: Please review the updated PR.

serhiy-storchaka
serhiy-storchaka reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tcl/Tk version 8.4 is required in 3.5.

Tcl/Tk version 8.3.1 is required in 3.1.

@serhiy-storchaka
Copy link
Member

The earliest versionchanged here is for 3.5, so I think we can omit 3.1, but add to 3.5.

@vstinner
Copy link
Member Author

Tcl/Tk version 8.4 is required in 3.5.
Tcl/Tk version 8.3.1 is required in 3.1.

Good to know. I completed the doc.

@serhiy-storchaka: Would you mind to review the updated PR?

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 30, 2023 •
edited
Loading

I'm not sure what it is worth, but here's more details on SQLite requirements:

  • 3.10: Require SQLite 3.7.15

@vstinner
Copy link
Member Author

3.10: Require SQLite 3.7.15

Added.

serhiy-storchaka
serhiy-storchaka approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems that other extension modules either shipped with some default version (like zlib or decimal), or do not have explicit version requirements.

@vstinner
Copy link
Member Author

Seems that other extension modules either shipped with some default version (like zlib or decimal), or do not have explicit version requirements.

If someone has information about minimum version, please go ahead and propose a doc PR :-) I don't recall any information about that.

@vstinner vstinner merged commit e012cf7 into python:main Aug 30, 2023
15 checks passed
@vstinner
Copy link
Member Author

Merged, I added Erlend and Serhiy as co-authors of the PR :-)

@vstinner vstinner deleted the doc_build_req branch August 30, 2023 13:29
carljm added a commit to carljm/cpython that referenced this pull request Aug 30, 2023
@carljm
Merge branch 'main' into icompexc
37377e6 
* main:
  pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)
  pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686)
  pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)
  Document Python build requirements (python#108646)
  pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)
  Fix typo in multiprocessing docs (python#108666)
  pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)
  pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)
  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)
  pythongh-106320: Remove private _Py_ForgetReference() (python#108664)
  Mention Ellipsis pickling in the docs (python#103660)
  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)
  pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)
  pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)
  pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @serhiy-storchaka @erlend-aasland @AA-Turner @bedevere-bot